[PATCH] Fixed switch warning in asus_oled.

19 views
Skip to first unread message

Tulin Izer

unread,
May 6, 2013, 9:54:11 PM5/6/13
to opw-k...@googlegroups.com
This patch fixes the warning about switch found by checkpatch.pl
in asus-oled driver. Default case should have 'break'.

Signed-off-by: Tülin İzer <tuli...@gmail.com>
---
drivers/staging/asus_oled/asus_oled.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index d0a5a28..6ff0146 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -401,7 +401,7 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)

default:
/* cannot get here; stops gcc complaining*/
- ;
+ break;
}

odev->buf_offs++;
--
1.7.9.5

Sarah Sharp

unread,
May 8, 2013, 1:08:27 AM5/8/13
to Tulin Izer, opw-k...@googlegroups.com
Hi Tulin,

Greg will have to review this, but I can verify that the patch
description looks fine, it applies, and the code looks good. The only
thing I notice is that your authorship information is missing accents,
but I have no idea what could cause that, so I think it's fine. :)

Congrats on a good first patch!

Sarah Sharp
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Tülin İzer

unread,
May 8, 2013, 5:21:21 AM5/8/13
to Sarah Sharp, opw-k...@googlegroups.com
  Hi Sarah,

 Thanks for your reply. I will work on that accent issue :)

Tülin İzer




2013/5/8 Sarah Sharp <sarah....@intel.com>
Reply all
Reply to author
Forward
0 new messages