Deprecated SslContextFactory

[Stéphane Vaucher]

Hi everyone,

I opened a PR, with a one line change to support jetty 9.4.23. In this new (upcoming version of jetty), there are checks that verify if a jetty user (like pax-web) uses SslContextFactory as opposed to SslContextFactory.Server. The current version of pax-web jetty may encounter an issue.

It's a simple one liner, replace new SslContextFactory() by new  SslContextFactory.Server()

Reference:

https://github.com/ops4j/org.ops4j.pax.web/pull/275 

 

Regards,

Stephane

--

-- 

Benchmark Consulting

460 rue St-Catherine St Ouest, Suite 612

Montréal, Québec H3B-1A7

(514) 798-2042 o

(514) 798-2044 f

CONFIDENTIALITY NOTICE: The information contained in this e-mail is confidential and may be proprietary information intended only for the use of the individual or entity to whom it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any viewing, dissemination, distribution, disclosure, copy or use of the information contained in this e-mail message is strictly prohibited. If you have received and/or are viewing this e-mail in error, please immediately notify the sender by reply e-mail, and delete it from your system without reading, forwarding, copying or saving in any manner. Thank you.

AVIS DE CONFIDENTIALITE: L’information contenue dans ce message est confidentiel, peut être protégé par le secret professionnel et est réservé à l'usage exclusif du destinataire. Toute autre personne est par les présentes avisée qu'il lui est strictement interdit de diffuser, distribuer ou reproduire ce message. Si vous avez reçu cette communication par erreur, veuillez la détruire immédiatement et en aviser l'expéditeur. Merci.

[Grzegorz Grzybek]

Hello Stephane

Looks like in https://github.com/ops4j/org.ops4j.pax.web/pull/275/files you've mixed your previous PR (which I didn't yet have time to review): https://github.com/ops4j/org.ops4j.pax.web/pull/272/files

Can you create two separate PRs? (fix PR #275 to include only this factory change)

kind regards

Grzegorz Grzybek

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ops4j/CAMiyyEx6%2BaCMOFgE%3DA934B7PBtAwY8YaaMWcAo4ArHeHqKGsjA%40mail.gmail.com.

[Stéphane Vaucher]

Sure, I'll cherry-pick the change out in a separate PR.

Stephane

To view this discussion on the web visit https://groups.google.com/d/msgid/ops4j/CAAdXmhri-pZSjxQYecFsafXzUAbdUQXfv_E_pUthCs%3DyAD60Gw%40mail.gmail.com.