[PAX-WEB] org.ops4j.lang.NullArgumentException: Context model is null

[Silvano Maffeis]

Hi

I'm using pax-web 7.3.5. In the activate() method of my OSGi bundle I'm doing the following:

final ServiceReference<WebContainer> ref = ctx.getServiceReference(WebContainer.class);
final WebContainer webCont = ctx.getService(ref);

webCont.registerWelcomeFiles(new String[] { "index.html" }, true, null);

and I'm getting the following error. I also tried with a non-null HttpContext, but I'm hitting the same exception:

org.apache.felix.log.LogException: org.ops4j.lang.NullArgumentException: Context model is null.
at org.ops4j.lang.NullArgumentException.validateNotNull(NullArgumentException.java:74)
at org.ops4j.pax.web.service.spi.model.Model.<init>(Model.java:27)
at org.ops4j.pax.web.service.spi.model.WelcomeFileModel.<init>(WelcomeFileModel.java:32)
at org.ops4j.pax.web.service.internal.HttpServiceStarted.registerWelcomeFiles(HttpServiceStarted.java:1005)
at org.ops4j.pax.web.service.internal.HttpServiceProxy.registerWelcomeFiles(HttpServiceProxy.java:364)

I'm on Apache Felix, not on Karaf.

Silvano

[Grzegorz Grzybek]

Hello

Was it working before (an upgrade)?

I believe no one predicted that someone could register ONLY welcome files, without servlets/filters... But I may be wrong ;)

Could be a good (?) candidate for unit test.

regards

Grzegorz Grzybek

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ops4j/CAMuHPN0hZtUpb065B8yD62JS%3De1qKb-4aDVXmAMfCf8mpzpQag%40mail.gmail.com.

[Silvano Maffeis]

This used to work with pax-web 4.2.7

[Achim Nierbeck]

Hi,

this use-case should work, so if it's not working anymore it's clearly a bug.

regards, Achim

Am Do., 12. Dez. 2019 um 18:15 Uhr schrieb Silvano Maffeis <sil...@maffeis.com>:

This used to work with pax-web 4.2.7

--
--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ops4j/CAMuHPN1KFcpPaNKpztYMPXmArSrOBb57As_jg7wqSsEAUUBdSw%40mail.gmail.com.

--

Apache Member

Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead
blog <http://notizblog.nierbeck.de/>

Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>

Software Architect / Project Manager / Scrum Master 

[Silvano Maffeis]

I've tried the newest 7.3.6 now and I'm still getting this NullPointerException:

org.apache.felix.log.LogException: org.ops4j.lang.NullArgumentException: Context model is null.
at org.ops4j.lang.NullArgumentException.validateNotNull(NullArgumentException.java:74)
at org.ops4j.pax.web.service.spi.model.Model.<init>(Model.java:27)
at org.ops4j.pax.web.service.spi.model.WelcomeFileModel.<init>(WelcomeFileModel.java:32)
at org.ops4j.pax.web.service.internal.HttpServiceStarted.registerWelcomeFiles(HttpServiceStarted.java:1005)
at org.ops4j.pax.web.service.internal.HttpServiceProxy.registerWelcomeFiles(HttpServiceProxy.java:364)

The use case is where only static resources are being exposes, and registerWelcomeFiles is called.
I hit the NPE trying to access the welcome page (index.html):

WebContainer webCont = ...

webCont.registerResources(urlPath, urlPath , httpContext);
webCont.registerWelcomeFiles(new String[] { "index.html" }, true, httpContext);

Silvano

On Thu, Dec 12, 2019 at 6:14 PM Silvano Maffeis <sil...@maffeis.com> wrote:

This used to work with pax-web 4.2.7

--

Silvano Maffeis

Dr. oec. publ.

[Grzegorz Grzybek]

Hello

I had your email marked as _unread_ for long time - sorry I didn't answer earlier...

I think the answer may be funnier and simpler than expected...

Most registerXXX() methods inside HttpServiceStarted call `org.ops4j.pax.web.service.internal.HttpServiceStarted#getOrCreateContext()` method. Only `org.ops4j.pax.web.service.internal.HttpServiceStarted#registerWelcomeFiles()` calls simply org.ops4j.pax.web.service.spi.model.ServiceModel#getContextModel(), so if the welcome files are first thing you do, no wonder you're getting null "context".

The reason is https://github.com/ops4j/org.ops4j.pax.web/commit/76a1042a84c9b14d2abbd3e97499919ae15536b6 commit from 4th August 2008...

I'm just checking org.ops4j.pax.web.itest.common.AbstractWebContainerIntegrationTest#testWelcomFiles test and everything works fine, because the sequence of registrations in org.ops4j.pax.web.samples.helloworld.wc.internal.Activator#start() starts with servlet registration...

so I have one recommendation - please register something before welcome pages ;)

I'm reviewing entire Pax Web in version 8 and the registrations will be done a bit different (but not much).

regards

Grzegorz Grzybek

--

--
------------------
OPS4J - http://www.ops4j.org - op...@googlegroups.com

---
You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+un...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ops4j/CAMuHPN2dYu1QE8kDp%2BZoj2OY4G0-KB6CGAyhmXQu4Oqn3idoAw%40mail.gmail.com.