"Assignee" vs "Reviewer" field in PRs

[Sean Lip]

Hi all,

GitHub has recently added functionality to PRs that allow you to request a review, which is great! Please feel free to use it -- in general, the best reviewer is probably the lead of the relevant GitHub project, or the author of the issue that's being fixed.

Also, note that PRs now have fields for assignees and for reviewers. To avoid confusion, this is what each field means:

• "Reviewers" are people who review the code.
• "Assignee" is the person who needs to take the next action. If the PR still needs to be reviewed, this is the reviewer. If the reviewer has completed a pass, and is waiting on the PR author to fix the PR, then the assignee should be the PR author.

This means that, after reviewing a PR, please change the assignee to the PR author to indicate that it's "their turn". Similarly, when submitting a PR for review, and after you've fixed changes in response to a review, please change the assignee to the reviewer.

If you have any questions, please ask! I'll update the instructions on the wiki shortly.

Thanks,

Sean