[oppia/oppia] d0141c: Fix #21445: Fix caching and make building a reusab...

[Sean Lip]

Branch: refs/heads/gh-readonly-queue/develop/pr-21509-b0baedfab12b2dafb82a63691fe36606918c648a
Home: https://github.com/oppia/oppia
Commit: d0141c35471ba1144bf19e1e06b04cf61be48cfb
https://github.com/oppia/oppia/commit/d0141c35471ba1144bf19e1e06b04cf61be48cfb
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-23 (Mon, 23 Dec 2024)

Changed paths:
A .github/actions/generate-build-files/action.yml
M .github/workflows/full_stack_tests.yml

Log Message:
-----------
Fix #21445: Fix caching and make building a reusable action (#21509)

* Fix caching and make building a reusable action

* Fix missing properties

* Make allowance for failure of download-artifact

* Accessibility tests don't need the files to be built.

* Overwrite artifact when reuploading



To unsubscribe from these emails, change your notification settings at https://github.com/oppia/oppia/settings/notifications

[Sean Lip]

Branch: refs/heads/develop

[Sean Lip]

Branch: refs/heads/cleanup-scripts

Home: https://github.com/oppia/oppia
Commit: d0141c35471ba1144bf19e1e06b04cf61be48cfb
https://github.com/oppia/oppia/commit/d0141c35471ba1144bf19e1e06b04cf61be48cfb
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-23 (Mon, 23 Dec 2024)

Changed paths:
A .github/actions/generate-build-files/action.yml
M .github/workflows/full_stack_tests.yml

Log Message:
-----------
Fix #21445: Fix caching and make building a reusable action (#21509)

* Fix caching and make building a reusable action

* Fix missing properties

* Make allowance for failure of download-artifact

* Accessibility tests don't need the files to be built.

* Overwrite artifact when reuploading

Commit: d8a9d0e2d6df288d1b6593ea0ed1d9b7028f8492
https://github.com/oppia/oppia/commit/d8a9d0e2d6df288d1b6593ea0ed1d9b7028f8492
Author: Sambhav Kaushik <92575005+m...@users.noreply.github.com>
Date: 2024-12-24 (Tue, 24 Dec 2024)

Changed paths:
A core/jobs/batch_jobs/reject_invalid_suggestion_and_delete_invalid_translation_jobs.py
A core/jobs/batch_jobs/reject_invalid_suggestion_and_delete_invalid_translation_jobs_test.py
M core/jobs/registry.py
M core/storage/base_model/gae_models_test.py
M scripts/backend_test_shards.json
M scripts/linters/test_files/valid_job_imports.py

Log Message:
-----------
Fix #20217, #20014: Beam jobs that rejects invalid translation suggestions and delete translations with invalid content ids (#21031)

* created files for new job

* created the beam job.

* wrote test for beam job

* fixed some errors

* completed the beam jobs, and tests for them.

* applying quick fixes form PR 21025

* shorten the file names

* fixed some mypy checks

* fixed the mypy tests

* added test file to test shard and some refactors.

* refactor

* Updated test and job logic

* Update

* Update

* Update

* update

* updating translation count after deleting translations.

* Fixing the failing test "test_generic_query_put_get_and_delete_operations"

* Update

* test coverage

* resolved context error

* Fixed more context issue

* quick fixes

* Update reject_invalid_suggestion_and_delete_invalid_translation_jobs.py

Changed job names and code improvement

* Update reject_invalid_suggestion_and_delete_invalid_translation_jobs_test.py

modified test cases

* updating last_updated field while rejecting suggestions

---------

Co-authored-by: Sean Lip <se...@seanlip.org>


Commit: d136d10fb644d93b4c3906e614d8f0a7957ee6b8
https://github.com/oppia/oppia/commit/d136d10fb644d93b4c3906e614d8f0a7957ee6b8
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-24 (Tue, 24 Dec 2024)

Changed paths:
M core/templates/components/forms/custom-forms-directives/image-uploader-modal.component.html
M core/tests/puppeteer-acceptance-tests/specs/curriculum-admin/create-edit-and-delete-classroom.spec.ts
M core/tests/puppeteer-acceptance-tests/utilities/user/curriculum-admin.ts
M core/tests/puppeteer-acceptance-tests/utilities/user/topic-manager.ts

Log Message:
-----------
Fix #20856: Fix commonly-occurring "node is not clickable" flake in the classroom admin page. (#21474)

* Fix some flakes in the classroom admin and topic editor pages.

* Fix incorrect element reference.


Commit: 5b0088bc96fbcdc83f7e696f3838ecde01ef2807
https://github.com/oppia/oppia/commit/5b0088bc96fbcdc83f7e696f3838ecde01ef2807
Author: imchristie <122439444+...@users.noreply.github.com>
Date: 2024-12-24 (Tue, 24 Dec 2024)

Changed paths:
M Makefile
M core/tests/puppeteer-acceptance-tests/specs/logged-in-user/create-and-delete-account.spec.ts
M scripts/servers.py

Log Message:
-----------
Remove detectOpenHandles and forceExit when running acceptance tests (#21493)

* Added test for i18n format

* Question Admin

* Added Functions for Question Admin

* Added Functions for Question Admin

* Added Functions for Question Admin

* Added Functions for Question Admin

* Update develop

* [GSoC'24] M1.11, Fix a part of #20374: Acceptance test coverage for a topic manger's CUJs (#20580)

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* [GSoC'24] M1.8, Fix a part of #20374: Acceptance test coverage for 2 Topics Manager's CUJs. (#20569)

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* Fix #20521: Fixed issues with AuthGuard for SubtopicViewerPage (#20579)

* fixed issues with auth guard

* fixed issues with tests

* fixed issues with frontend tests

* fixed linting issues

* Fix issue #20617: 'Blog Post Title' is now visible in the Blog Post Editor (#20634)

* Added necessary CSS properties to fix position of blog-post-title

* Changed position of blog-post-title on mobile viewport

* Removed bottom property to center the blog-post-title

---------

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>

* Moves AUTO_UPDATE_EXP_VOICE_ARTIST_LINK feature flag to prod (#20658)

Moves feature flag to prod

* Fix part of #18384: Base of new progress tab for learner dashboard redesign (#20522)

* Added feature flags

* refactored and replaced with new components community lessons (new progress tab)

* Replaced innerHtml

* Updated translation keys

* Updated variable names to match #20306

* Added notes, renamed card-display, updated temp progress value for explorations/collections

* Fixed lint issues

* Removed unused tag

* Adjusted spacing

* Last adjustment

* Fixed content sizing for screens > 1512 (prevent shrink if not enough obj)

* Fixed e2e error

* Renamed communityComplete variable

* Renamed feature flag for community lessons

---------

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>

* Fixing: #20641, The Signature is not visible clearly in mobile devices when the word count is too large (#20646)

increasing height in mobile device

* Fix part of #18921: Replace user-referenced TODO comments with issue-referenced TODO comments (#20464)

Part fix of #18921

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>

* [GSoC' 24] Fixes #20671 and general M1 fixes. (#20657)

* Updates

* Updates

* Updates

* Debugging

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Fix #20304: updated Makefile to start dsadmin (#20425)

* updated Makefile to start dsadmin

* added required changes

* restored index.yaml with develop

* removed xdg-open from dsadmin

---------

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>

* [GSoC'24] Modify translations bug fixes (#20666)

* Improve modal CSS

* Tick checkbox on saving a translation

* Update button text for clarity

* Show subsidiary modal only when editable translations exist

* Verify if RTE components of modified translation match when updating translation

* Add missing languages to supported content language list

* Fix frontend tests

* Fix acceptance test

* Fix bugs pertaining to stale and empty translations

* Fix linter issues

* Gate translation changes button behind feature flag

* Fix frontend test

* Fix rules display bug

* Implement part of #17712 : Acceptance tests for Exploration editor Section(CUJ 12). (#20669)

* Exploration-editor-CUJ-12

* Add proper specs

* Add proper specs

* changes

* [GSoC'24]M2.1 Redesign volunteer page (#20667)

* Redesign volunteer page

* fix tests

* fix the tests

* Fix rtl issues

* fix lighthouse tests

* Address review comments 1

* change lexico order

* [GSoC'24] Fix #20652, and #20649: Fixes the respective two flakes. (#20672)

* updates

* updates

* updates

* Fix #20787 and #20788: Allow naming of merge from develop steps in GitHub Workflows (#20907)

* Allow naming of merge from develop steps in GitHub Workflows

* Modify existing test for merge step

* Add a linter to require that all GitHub workflow steps be named

* Add tests for requiring steps to be named and fix minor details in merge step test

* Add names for workflow steps

* Fix grammar mistakes in comments

---------

Co-authored-by: Sean Lip <se...@seanlip.org>
Co-authored-by: Akhilesh Kr. <2827...@gmail.com>

* Fix part of #20001: Make pre-push hook more efficient. (#20905)

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

---------

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>
Co-authored-by: Akhilesh Kr. <2827...@gmail.com>

* Fix #20779: Makefile env PATH fix on WSL (#20780)

* makefile fixed

* Explaining comments

* Explaining FIXED_PATH with comments

* removed extra comment

---------

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>
Co-authored-by: Akhilesh Kr. <2827...@gmail.com>

* Fix #20399: Added tests for POST, PUT and DELETE and error handling for invalid method using 405 status code. (#20544)

* Added no 500 error tests for post put and delete. Also added 405 status code handling for invalid requests.

* Fixed linting issues

* Fixed more linting issues

* Fixed even more linting issues

* Fixed MyPy issues

* Fixed linting issues

* Fixed backend test error and updated 405 error message.

* Fixed linting errors

* Fixed linting errors

* Added requested formatting change

Co-authored-by: Vojtěch Jelínek <vojtech...@hey.com>

* Added requested formatting changes

* Made changes so that load_templates is only used for GET

* Made the requested changes

* Fixed linting issue

* Fixed failing backend test, made assertion for http_method neater

* Fixed backend test and made requested changes

* Fixed Mypy check error

* Fixed Mypy error by importing Any from typing

* Fixed linting errors

* Added comment to address why type Any is used

* Made requested changes in profile_test

* Updated comment about mock_add_user_to_raise_exception in profile_test

* Updated comment about mock_add_user_to_raise_exception in profile_test

* Made requested changes

* Fixed failing backend, linter and MyPy tests

* Fixed failing linter tests

* Fixed failing linter tests

* Fixed failing MyPy tests

* Added comment

* Fixed linting issues

* Added correct types in profile_test

* Corrected if block and typo

* Added test to fix failing backend coverage

* Fixed linting issues

* Fixed Mypy issues

---------

Co-authored-by: Vojtěch Jelínek <vojtech...@hey.com>
Co-authored-by: Sean Lip <se...@seanlip.org>
Co-authored-by: Akhilesh Kr. <2827...@gmail.com>

* Fix part of#19849: Multiple classrooms bug fixes (#20904)

* Fix part of#19849: Multiple classrooms bug fixes

* fix classrooms page alignment

* nit

* add classroom name and url fragment

* fix type

* add classroom name

* show classroom name

* fix test

* fix overflow

---------

Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>
Co-authored-by: Akhilesh Kr. <2827...@gmail.com>

* Fix part of #19435: Review test page migration (#20790)

* review tests page migration

* *lint fix

* lint fix

* Reverting import changes

---------

Co-authored-by: Akhilesh Kr. <2827...@gmail.com>
Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>

* fix lint

* added new line

* added new line

* same as upstream

* deleted zone.identifier

* deleted detechOpenHandles and forceExit

* added closeBrowser

* added comments in create-delete-account

---------

Co-authored-by: Akhilesh Kr <2827...@gmail.com>
Co-authored-by: Harshvardhan Singh <73544247+...@users.noreply.github.com>
Co-authored-by: Bryan Khor <67664138+b...@users.noreply.github.com>
Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>
Co-authored-by: Nikhil <nikhil.ag...@gmail.com>
Co-authored-by: amyyeung17 <amyye...@gmail.com>
Co-authored-by: Mannika <84311047+...@users.noreply.github.com>
Co-authored-by: Oluwapolore Oyeniji <90858072+po...@users.noreply.github.com>
Co-authored-by: Justin Nguyen <70992422+...@users.noreply.github.com>
Co-authored-by: Jayam Patel <jayamp...@gmail.com>
Co-authored-by: Vir Kothari <7332925...@users.noreply.github.com>
Co-authored-by: Rahat <136263179...@users.noreply.github.com>
Co-authored-by: Akash Paloju <119884665+...@users.noreply.github.com>
Co-authored-by: Ali Orozgani <40970649...@users.noreply.github.com>
Co-authored-by: Sean Lip <se...@seanlip.org>
Co-authored-by: Priyanshu Verma <priyans...@outlook.in>
Co-authored-by: Mohit Ruwatia <12043831...@users.noreply.github.com>
Co-authored-by: Vojtěch Jelínek <vojtech...@hey.com>
Co-authored-by: Afzal Khan <trick...@gmail.com>


Commit: 30a72bb60a189ab961e9712262fbdf0a32ceb332
https://github.com/oppia/oppia/commit/30a72bb60a189ab961e9712262fbdf0a32ceb332
Author: Kartik Suryavanshi <158498247+Kar...@users.noreply.github.com>
Date: 2024-12-24 (Tue, 24 Dec 2024)

Changed paths:
M core/templates/pages/exploration-player-page/layout-directives/audio-bar.component.html

Log Message:
-----------
Fix: Removed horizontal focus line on Fractions page (#21335)

Co-authored-by: Sean Lip <se...@seanlip.org>
Co-authored-by: Hardik Goyal <135348086+Ha...@users.noreply.github.com>


Commit: 041ee8d5e45460bcc962c7b40ddcc11c69df6bcc
https://github.com/oppia/oppia/commit/041ee8d5e45460bcc962c7b40ddcc11c69df6bcc
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-25 (Wed, 25 Dec 2024)

Changed paths:
A .github/actions/generate-build-files/action.yml
M .github/workflows/full_stack_tests.yml

M Makefile
A core/jobs/batch_jobs/reject_invalid_suggestion_and_delete_invalid_translation_jobs.py
A core/jobs/batch_jobs/reject_invalid_suggestion_and_delete_invalid_translation_jobs_test.py
M core/jobs/registry.py
M core/storage/base_model/gae_models_test.py
M core/templates/components/forms/custom-forms-directives/image-uploader-modal.component.html
M core/templates/pages/exploration-player-page/layout-directives/audio-bar.component.html
M core/tests/puppeteer-acceptance-tests/specs/curriculum-admin/create-edit-and-delete-classroom.spec.ts
M core/tests/puppeteer-acceptance-tests/specs/logged-in-user/create-and-delete-account.spec.ts
M core/tests/puppeteer-acceptance-tests/utilities/user/curriculum-admin.ts
M core/tests/puppeteer-acceptance-tests/utilities/user/topic-manager.ts
M scripts/backend_test_shards.json
M scripts/linters/test_files/valid_job_imports.py
M scripts/servers.py

Log Message:
-----------
Merge branch 'develop' into cleanup-scripts


Commit: c0103600659c113f2372a0d7a09a91249499cfe2
https://github.com/oppia/oppia/commit/c0103600659c113f2372a0d7a09a91249499cfe2
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-25 (Wed, 25 Dec 2024)

Changed paths:
M scripts/pre_commit_hook_test.py

Log Message:
-----------
fix backend test


Compare: https://github.com/oppia/oppia/compare/0c2c9d9dbeb1...c0103600659c