Branch: refs/heads/gh-readonly-queue/develop/pr-21372-a4fbb78c4c5a68540919d61b7212c49d6139f47b
Home:
https://github.com/oppia/oppia
Commit: d97110df23e680fb7708e7f6987a617f6c8bb6d3
https://github.com/oppia/oppia/commit/d97110df23e680fb7708e7f6987a617f6c8bb6d3
Author: amyyeung17 <
amyye...@gmail.com>
Date: 2024-12-27 (Fri, 27 Dec 2024)
Changed paths:
M core/templates/components/summary-tile/lesson-card.component.spec.ts
M core/templates/components/summary-tile/lesson-card.component.ts
M core/templates/pages/learner-dashboard-page/community-lessons-tab.component.html
M core/templates/pages/learner-dashboard-page/community-lessons-tab.component.ts
M core/templates/pages/learner-dashboard-page/goal-list/goal-list.component.html
M core/templates/pages/learner-dashboard-page/goal-list/goal-list.component.ts
M core/templates/pages/learner-dashboard-page/home-tab.component.html
M core/templates/pages/learner-dashboard-page/home-tab.component.spec.ts
M core/templates/pages/learner-dashboard-page/home-tab.component.ts
Log Message:
-----------
Fix part of #18384: Replaced placeholder data with all lessons in home & added recommended lessons (#21372)
* Find stories with at least 1+ available nodes to recommend, not counting current. Ids are stored in storySummariesWithAvailableNodes in home-tab.
* Corrected if statement when finding if there are nodes available to recommend. Added test cases.
* Corrected test case for home-tab
* Added isRecommendation to lesson-card component. If true, returns nextStory as 1 + current lesson; the current is assumed to be the earliest incomplete node.
* Lesson card component - shows next incomplete title if isRecommendation is true (recommendation card)
* Rearranged user data in home tab
* Find total in-progress lesson count for home-tab
* Add goal tags to completed lessons in new progress tab.
* Fixed lesson being recommended in case of unordered, interspersed completed nodes in lesson-card component. Changed some notes and made recommended lessons only display if there are classroom lessons in-progress.
* Replaced how canonicalStorySummaryDicts were being accessed in goal-list files to follow best practices
* TS errors fix
* Added test coverage for lesson-card
* Delete TODO comment
---------
Co-authored-by: Sean Lip <
se...@seanlip.org>
To unsubscribe from these emails, change your notification settings at
https://github.com/oppia/oppia/settings/notifications