[oppia/oppia] fbf078: Fix #18795: Remove the function convert_millisecs...

0 views
Skip to first unread message

Somnath Mishra

unread,
Dec 25, 2024, 10:19:30 PM12/25/24
to oppia-de...@googlegroups.com
Branch: refs/heads/gh-readonly-queue/develop/pr-21205-d2c6e88a19079304cb8bdb28ed0d9d2542aa4e28
Home: https://github.com/oppia/oppia
Commit: fbf0783e08923118b60436fcc60509be9c99b77a
https://github.com/oppia/oppia/commit/fbf0783e08923118b60436fcc60509be9c99b77a
Author: Somnath Mishra <120735604+So...@users.noreply.github.com>
Date: 2024-12-26 (Thu, 26 Dec 2024)

Changed paths:
M core/controllers/access_validators_test.py
M core/controllers/learner_group_test.py
M core/controllers/review_tests_test.py
M core/controllers/story_viewer_test.py
M core/controllers/topic_editor.py
M core/controllers/topic_editor_test.py
M core/domain/story_domain.py
M core/domain/story_domain_test.py
M core/domain/story_services_test.py
M core/domain/topic_services_test.py
M core/jobs/batch_jobs/story_migration_jobs_test.py
M core/templates/components/summary-tile/learner-story-summary-tile.component.spec.ts
M core/templates/components/summary-tile/learner-topic-goals-summary-tile.component.spec.ts
M core/templates/components/summary-tile/learner-topic-summary-tile.component.spec.ts
M core/templates/components/summary-tile/lesson-card.component.spec.ts
M core/templates/domain/learner_dashboard/learner-dashboard-backend-api.service.spec.ts
M core/templates/domain/learner_group/learner-group-syllabus-backend-api.service.spec.ts
M core/templates/domain/learner_group/learner-group-syllabus.model.spec.ts
M core/templates/domain/learner_group/learner-group-user-progress.model.spec.ts
M core/templates/domain/story/editable-story-backend-api.service.spec.ts
M core/templates/domain/story/story-contents-object.model.spec.ts
M core/templates/domain/story/story-node.model.spec.ts
M core/templates/domain/story/story-summary.model.spec.ts
M core/templates/domain/story/story-update.service.spec.ts
M core/templates/domain/story/story-validation.service.spec.ts
M core/templates/domain/story/story.model.spec.ts
M core/templates/domain/topic/learner-topic-summary.model.spec.ts
M core/templates/domain/topic_viewer/read-only-topic-object.factory.spec.ts
M core/templates/domain/topic_viewer/topic-viewer-backend-api.service.spec.ts
M core/templates/pages/learner-dashboard-page/community-lessons-tab.component.spec.ts
M core/templates/pages/learner-dashboard-page/goal-list/goal-list.component.spec.ts
M core/templates/pages/learner-dashboard-page/goals-tab.component.spec.ts
M core/templates/pages/learner-dashboard-page/home-tab.component.spec.ts
M core/templates/pages/learner-dashboard-page/progress-tab.component.spec.ts
M core/templates/pages/learner-dashboard-page/skill-card/skill-card.component.spec.ts
M core/templates/pages/learner-group-pages/edit-group/learner-group-learner-specific-progress.component.spec.ts
M core/templates/pages/learner-group-pages/edit-group/learner-group-learners-progress.component.spec.ts
M core/templates/pages/learner-group-pages/edit-group/learner-group-overview.component.spec.ts
M core/templates/pages/learner-group-pages/view-group/learner-group-view-assigned-syllabus.component.spec.ts
M core/templates/pages/story-editor-page/editor-tab/story-editor.component.spec.ts
M core/templates/pages/story-editor-page/editor-tab/story-node-editor.component.spec.ts
M core/templates/pages/story-editor-page/navbar/story-editor-navbar-breadcrumb.component.spec.ts
M core/templates/pages/story-editor-page/navbar/story-editor-navbar.component.spec.ts
M core/templates/pages/story-editor-page/services/story-editor-staleness-detection.service.spec.ts
M core/templates/pages/story-editor-page/story-preview-tab/story-preview-tab.component.spec.ts
M core/utils.py
M core/utils_test.py

Log Message:
-----------
Fix #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses (#21205)

* fix #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fix #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fix #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fix #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fixing bug #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fixing bug #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fixing bug #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* fixing bug #18795: Remove the function convert_millisecs_time_to_datetime_object and its uses

* replacing actual config of karma.conf.ts

* replacing actual config of karma.conf.ts

* removing unnecessary if-else block

* fix coverage issue

* fix validation issue

* adding test for line 881, 887, 893 in core/domain/story_domain.py

---------

Co-authored-by: Sean Lip <se...@seanlip.org>



To unsubscribe from these emails, change your notification settings at https://github.com/oppia/oppia/settings/notifications

Somnath Mishra

unread,
Dec 26, 2024, 4:05:06 AM12/26/24
to oppia-de...@googlegroups.com
Branch: refs/heads/develop

Sean Lip

unread,
Dec 26, 2024, 4:31:14 AM12/26/24
to oppia-de...@googlegroups.com
Branch: refs/heads/rate-limit
Commit: c8ee9afb5893dcca103e8e9e5852f46e3d8f7554
https://github.com/oppia/oppia/commit/c8ee9afb5893dcca103e8e9e5852f46e3d8f7554
Author: Mayank Mohapatra <125661248+Ma...@users.noreply.github.com>
Date: 2024-12-26 (Thu, 26 Dec 2024)

Changed paths:
M .github/workflows/all_lint_checks.yml
M .github/workflows/all_type_checks.yml
M .github/workflows/backend_unit_tests.yml
M .github/workflows/frontend_unit_tests.yml
M .github/workflows/full_stack_tests.yml
M .github/workflows/notify_if_pending_reviews.yml
M .github/workflows/notify_on_first_two_prs_merged.yml
M .github/workflows/oppiabot.yml
M .github/workflows/revert-web-wiki-updates.yml
M scripts/common_test.py

Log Message:
-----------
Fix #20112: Restricted GITHUB_TOKEN permissions on GitHub Actions (#21507)

* permission levels fixed

* oppiabot , test and remaining two permission levels added

* lint checks

* lint checks

* lint checks

* recommendations added

* lint checks


Commit: 1e52f9bcf5e92e27f364d067879abf4bf85f32ea
https://github.com/oppia/oppia/commit/1e52f9bcf5e92e27f364d067879abf4bf85f32ea
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-26 (Thu, 26 Dec 2024)

Changed paths:
M .github/workflows/all_lint_checks.yml
M .github/workflows/all_type_checks.yml
M .github/workflows/backend_unit_tests.yml
M .github/workflows/frontend_unit_tests.yml
M .github/workflows/full_stack_tests.yml
M .github/workflows/notify_if_pending_reviews.yml
M .github/workflows/notify_on_first_two_prs_merged.yml
M .github/workflows/oppiabot.yml
M .github/workflows/revert-web-wiki-updates.yml
M scripts/common_test.py

Log Message:
-----------
Merge branch 'develop' into rate-limit


Compare: https://github.com/oppia/oppia/compare/5f6fba666784...1e52f9bcf5e9

Sean Lip

unread,
Dec 26, 2024, 4:31:33 AM12/26/24
to oppia-de...@googlegroups.com
Branch: refs/heads/cleanup-scripts
Commit: ee9a8c8e902e8198d72e063e847efb00a0bc7bf6
https://github.com/oppia/oppia/commit/ee9a8c8e902e8198d72e063e847efb00a0bc7bf6
Merge branch 'develop' into cleanup-scripts


Compare: https://github.com/oppia/oppia/compare/13ffce31434c...ee9a8c8e902e

Sean Lip

unread,
Dec 26, 2024, 4:36:03 AM12/26/24
to oppia-de...@googlegroups.com
Branch: refs/heads/use-cache
Commit: ea797cdaac73469aff878d504da54ee76e47e4d3
https://github.com/oppia/oppia/commit/ea797cdaac73469aff878d504da54ee76e47e4d3
Merge branch 'develop' into use-cache


Commit: 517c2f48660eaa2d29b155a1ad1ec8f12d11b836
https://github.com/oppia/oppia/commit/517c2f48660eaa2d29b155a1ad1ec8f12d11b836
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-26 (Thu, 26 Dec 2024)

Changed paths:
M .github/actions/install-oppia-dependencies/action.yml

Log Message:
-----------
Fix missing shell cmd


Compare: https://github.com/oppia/oppia/compare/71aa6f2bfd98...517c2f48660e

Sean Lip

unread,
Dec 26, 2024, 5:56:20 AM12/26/24
to oppia-de...@googlegroups.com
Branch: refs/heads/drop-obs
Commit: 99e2a3e49341994380cb640d09ac4c3d91ccd73d
https://github.com/oppia/oppia/commit/99e2a3e49341994380cb640d09ac4c3d91ccd73d
Merge branch 'develop' into drop-obs


Commit: 985460f167544bafb70c25c5e098178949f71698
https://github.com/oppia/oppia/commit/985460f167544bafb70c25c5e098178949f71698
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-26 (Thu, 26 Dec 2024)

Changed paths:
M core/jobs/batch_jobs/exp_migration_jobs.py
M extensions/objects/models/objects_test.py
M extensions/rich_text_components/components.py
M extensions/visualizations/models_test.py
M scripts/build.py
M scripts/build_test.py
M scripts/common_test.py
M scripts/extend_index_yaml.py
M scripts/install_python_prod_dependencies_test.py
M scripts/linters/js_ts_linter.py
M scripts/linters/pylint_extensions_test.py
M scripts/pre_push_hook.py
M scripts/run_acceptance_tests_test.py
M scripts/run_e2e_tests_test.py

Log Message:
-----------
Fix lint and tests.


Compare: https://github.com/oppia/oppia/compare/72d830836327...985460f16754

Sean Lip

unread,
Dec 26, 2024, 10:17:37 AM12/26/24
to oppia-de...@googlegroups.com
Branch: refs/heads/comment
Commit: 987ac55cda7dbbc0e95aa8d1a39b13f0dd1e3421
https://github.com/oppia/oppia/commit/987ac55cda7dbbc0e95aa8d1a39b13f0dd1e3421
Merge branch 'develop' into comment


Commit: ce80373193e63d246bb325186295a73500d51276
https://github.com/oppia/oppia/commit/ce80373193e63d246bb325186295a73500d51276
Author: Sean Lip <se...@seanlip.org>
Date: 2024-12-26 (Thu, 26 Dec 2024)

Changed paths:
M .github/actions/post-comment/action.yml

Log Message:
-----------
Change how post-comment action handles secret


Compare: https://github.com/oppia/oppia/compare/dd97479ebddc...ce80373193e6
Reply all
Reply to author
Forward
0 new messages