Building wraps with resource files fails (OpenWrap 2.0)

[Ruben Vandeginste]

I am using the beta repository (http://wraps.openwrap.org/beta/) for
both projects and system.

I'm trying to build a wrap from a project that includes translated
resources. However, this does not seem to work as intended.

I see the following problems:

1. building project in: ../../scratch/bin/myproj-bla-bla/ (yup,
copied from openwrap)

resources dll placed in ../../scratch/bin/myproj-bla-bla/nl/resources.dll
result: resources dll is not included in generated wrap

2. building project in: bin/Debug/

resources dll placed in bin/Debug/nl/resources.dll
result: resources dll is included in generated wrap, in
bin-net35/bin/Debug/nl/resources.dll

What I notice in the output when building the wrap:
Copying: bin-net35\bin\Debug\nl/resources.dll

Notice the mix of forward and backward slashes? Does this have
something to do with it?

Is there something I am doing wrong, or is this a bug?

cheers,
Ruben

[Sebastien Lambla]

I don't think slashes are the problem (unless msbuild does silly things), we use the Path APIs under the scene so segments ought to be recognized properly.

Resources ought to be handled in the msbuild output, relative to the outdir, i'm surprised this does not work. Can you add an issue on github and i'll have a look tonight, as I'm in the process of touchign that area of the code anyway...

________________________________________
From: openwra...@googlegroups.com [openwra...@googlegroups.com] on behalf of Ruben Vandeginste [ruben.va...@gmail.com]
Sent: 25 October 2011 10:35
To: openwra...@googlegroups.com
Subject: [openwrap-devl] Building wraps with resource files fails (OpenWrap 2.0)

[Ruben Vandeginste]

Ok, created issue #268.

thanks for looking at it,
Ruben

[Ruben Vandeginste]

Sebastien,

This issue is starting to get urgent for us. Can you give me a couple
of quick hints where I should go check in the source to debug and find
out what's going wrong?

thanks,
Ruben

[Sebastien Lambla]

I'm just on it now. Temporarily, you can customize where things go by adding your own instruction inside your msbuild file as per https://github.com/openrasta/openwrap/wiki/Building-packages

________________________________________
From: openwra...@googlegroups.com [openwra...@googlegroups.com] on behalf of Ruben Vandeginste [ruben.va...@gmail.com]

Sent: 27 October 2011 11:18
To: openwra...@googlegroups.com
Subject: Re: [openwrap-devl] Building wraps with resource files fails (OpenWrap 2.0)

[Sebastien Lambla]

There will be a patch, you can expect binary releases for 2.0.2, probably on monday.
________________________________________
From: openwra...@googlegroups.com [openwra...@googlegroups.com] on behalf of Sebastien Lambla [s...@serialseb.com]
Sent: 27 October 2011 11:39
To: openwra...@googlegroups.com
Subject: RE: [openwrap-devl] Building wraps with resource files fails (OpenWrap 2.0)

[Ruben Vandeginste]

Thank you! Looking forward to it.

[Ruben Vandeginste]

Sebastien,

I found that the latest release did not fix the handling of resource
files. In addition, we also need to be able to handle contract
reference assemblies. So, I tried to fix it myself. The problem with
the resource files was that the relative path was not computed
correctly. I added the contract reference assemblies in the same way
as the handling of the satellite assemblies. I also added/changed some
things in the MSBuild tasks. I changed the publish-wrap command to
refresh the packages in the current directory before doing the lookup;
the reason is that I created an MSBuild script to do the
update-build-publish cycle, and the refresh is needed to "see" the
freshly created package in the publish part.

You can see my changes at:
https://github.com/racv/openwrap/commit/24eaf7bb3c095445c5012ccbdd181f81ce366c5c

I know I should have split up those changes in several separate
commits, but well...

Ruben

On Fri, Oct 28, 2011 at 12:58 PM, Ruben Vandeginste

[Sebastien Lambla]

That's brilliant, thanks for this.

I'll comment on the commit, I think it's small enough that it's good as it is :)

________________________________________
From: openwra...@googlegroups.com [openwra...@googlegroups.com] on behalf of Ruben Vandeginste [ruben.va...@gmail.com]

Sent: 08 November 2011 01:03

[Ruben Vandeginste]

Hey,

I added my comments on your comments. Can you check those?
I'll fix the patch probably friday or this weekend.

Not that familiar with git... I can just add an extra commit to fix
the current commit, and then you just pull both commits?
Or is there a better way to fix the commit that I have now?

Ruben

[Sebastien Lambla]

I'd say the easiest way is to rebase --interactive (find the last sha before your changes in git log, do git rebase sha --interactive), then squash the commits together into one. Once that's done, do your changes, commit --amend to include those in your checkin. Then you jus tneed to force a push to overwrite the existing brnach (git push --force)

________________________________________
From: openwra...@googlegroups.com [openwra...@googlegroups.com] on behalf of Ruben Vandeginste [ruben.va...@gmail.com]

Sent: 09 November 2011 08:52