OTP Review Process
25 views
Skip to first unread message
Thomas Gran
May 4, 2021, 10:07:46 AM5/4/21
to OpenTripPlanner Developers
THE OTP REVIEW PROCESS
Today I have created a new Team on GitHub to manage access to OTP reviews. The process is: 2 reviews from a member of the PLC team was required for OTP1 and one review for OTP2. THIS HAVE NOT CHANGED, but the Team responsible for approving reviews have changed. The new team is:
OTP Review Team (otp-review-team)
I did this, because the people in the PLC committee and the people that the PLC committee delegate the review privileges too is not the same. I am not sure if we need a PLC Team at GitHub, it could be used to restrict access to a limited set of files within the OTP repo - if needed. Until now the practice have been to add people witch should do reviews to the PLC Team (witch is confusing, since they are not PLC members). There is a list of PLC members in the PLC meeting notes and in the OTP documentation, so no need to duplicate that information as a group on GitHub.
CHANGES: PLC TEAM vs OTP REVIEW TEAM
Not every member of the PLC or member with write access is added to the "OTP Review Team". I did my best to include all active members by looking through through the PLC Team, the Commiters Team and the list of all contributors to the OTP project since JAN 2017. I tried to add everyone I know have been involved in the review process in the paset.
IF I MISSED SOMEONE, I APPOLOGISE, AND PLEASE LET ME KNOW SO I CAN ADD YOU TO TO THE OTP REVIEW TEAM.
AGILE PROCESS
If someone want to become a member of the review team we usually add the person, and then inform the PLC on the next PLC meeting.
The amount of contributions to OTP2 is very good at the moment, so to keep up with reviews 2 new developers i added to the list:
- Zsombor Welker, Hungary
- Leonard Ehrenfried, Germany
Thomas
Today I have created a new Team on GitHub to manage access to OTP reviews. The process is: 2 reviews from a member of the PLC team was required for OTP1 and one review for OTP2. THIS HAVE NOT CHANGED, but the Team responsible for approving reviews have changed. The new team is:
OTP Review Team (otp-review-team)
I did this, because the people in the PLC committee and the people that the PLC committee delegate the review privileges too is not the same. I am not sure if we need a PLC Team at GitHub, it could be used to restrict access to a limited set of files within the OTP repo - if needed. Until now the practice have been to add people witch should do reviews to the PLC Team (witch is confusing, since they are not PLC members). There is a list of PLC members in the PLC meeting notes and in the OTP documentation, so no need to duplicate that information as a group on GitHub.
CHANGES: PLC TEAM vs OTP REVIEW TEAM
Not every member of the PLC or member with write access is added to the "OTP Review Team". I did my best to include all active members by looking through through the PLC Team, the Commiters Team and the list of all contributors to the OTP project since JAN 2017. I tried to add everyone I know have been involved in the review process in the paset.
IF I MISSED SOMEONE, I APPOLOGISE, AND PLEASE LET ME KNOW SO I CAN ADD YOU TO TO THE OTP REVIEW TEAM.
AGILE PROCESS
If someone want to become a member of the review team we usually add the person, and then inform the PLC on the next PLC meeting.
The amount of contributions to OTP2 is very good at the moment, so to keep up with reviews 2 new developers i added to the list:
- Zsombor Welker, Hungary
- Leonard Ehrenfried, Germany
Thomas
Reply all
Reply to author
Forward
0 new messages