Resolving onboarding tips from plugin

41 views
Skip to first unread message

Brad Hards

unread,
Mar 21, 2018, 2:53:34 AM3/21/18
to OpenSphere
It looks like the opensphere-build-resolver takes care of most things in a plugin, but it doesn't appear to deal with onboarding (tips) JSON files. They work in debug builds, but don't get compiled in.

I've created tickets and PRs for this, but the build-resolver one needs to go in first, otherwise it'll die in the build (because of the missing file, which shows in Travis CI).
See
https://github.com/ngageoint/opensphere-build-resolver/pull/15
and
https://github.com/ngageoint/opensphere/pull/207

I do have a question about whether it would be possible to share code between the two build-resolver plugins (copy-views and copy-onboarding)? I didn't see an easy way to have a shared base class without changing the core resolver plugin code, so for now its almost duplicate code.

Brad

plagu...@gmail.com

unread,
Mar 21, 2018, 7:06:38 PM3/21/18
to OpenSphere
It should be fairly straightforward to create a file with the functions you need and require that file in both plugins (or have one plugin require the other).
Reply all
Reply to author
Forward
0 new messages