Multilingual song

[Aki Lankinen]

Hi,

Am I missing something or is multilingual song feature broken? I tried out this feature first time and only verse is formated correctly (see attached screen capture).

What could be wrong?

 Aki

[Gareth Evans]

Yep, that's a bug that I hadn't spotted - thank you for letting me know!

Verses without numbers (i.e. [VL]) are identified as multilingual, but I copied this for chorus, bridge, tag sections and wrongIy set the app to look for [VC], [VB], [VT] rather than the correct [CL], [BL], [TL] headings.  If you have a numbered sections, e.g. C1L, it will work, it was only broken for the non-numbered options.

Fix will be in the next release.

Gareth

[Aki Lankinen]

Great that you found the cause! I'll use numbered choruses meanwhile. 

Do you create unit tests for your code? These kind of bugs would be spotted quite easily with them. 

 Aki

[Gareth Evans]

Hi Aki,

I'm not sure what you mean with 'unit tests'.  When I add new features, I simply test on my devices as best as I then uploaded the changes to GitHub and also publish to the beta channel on Google play.  If I don't see crashes coming in, I then push the update to the stable channel. 

Gareth

--
When responding to a post on the forum using your email, please make sure to click on the 'Reply all' button so that your response is also sent to the forum for other people to see the full conversation.
---
You received this message because you are subscribed to the Google Groups "OpenSongApp" group.
To unsubscribe from this group and stop receiving emails from it, send an email to opensongapp...@googlegroups.com.
To view this discussion, visit https://groups.google.com/d/msgid/opensongapp/02638ce6-244b-4a75-845c-98a9c11ab742n%40googlegroups.com.

[Gareth Evans]

I have read a bit on unit tests, and have just given it a go with one of my functions.  I suspect there's a bit of a learning curve, but have found there are so many more issues (referring to other classes, interfaces, functions, variables, etc.) that it seems the test unit would be almost entirely different code and would introduce different errors when returning it to the main app.