Comment on revision r156 in opensocial-java-client

[codesite...@google.com]

Comment by drgenejones:

Score: Positive

General Comment:
I support the change it may need amending see comment.

Line-by-line comments:

File:
/branches/pre_1.0/java/src/org/opensocial/client/OpenSocialRequestValidator.java
(r156)
===============================================================================

Line 124: if ((scheme.equals("http") && port != 80)
-------------------------------------------------------------------------------
When I force this function to return a value of the
type: "http://www.acme.com/foo" to use in HMAC authentication. It works
fine and the url gets validated. However if I use this function as is it
returns "http://www.acme.com:0/foo" which then causes validation to fail.
I am using a Gmail Contextual Gadget validating against a Google App Engine
- Java remote server.

Do we need to add port "0" to this if statement?

For more information:
http://code.google.com/p/opensocial-java-client/source/detail?r=156