Re: Social-Gadget.xml (issue157078)

0 views
Skip to first unread message

api.ll...@gmail.com

unread,
Nov 23, 2009, 12:40:46 PM11/23/09
to opensocial-an...@googlegroups.com, jon.we...@gmail.com, re...@codereview.appspotmail.com
Thanks for the review Jon. Responses inline...

On 2009/11/19 18:39:23, Jon Weygandt wrote:
> Looks good.

> http://codereview.appspot.com/157078/diff/1/3
> File Social-Gadget.xml (left):

> http://codereview.appspot.com/157078/diff/1/3#oldcode44
> Social-Gadget.xml:44: <section title="Using the API Reference">
> On 2009/11/19 02:23:23, Lane wrote:
> > Moved Using the API reference to the Core-Gadget spec.

> I did not find this section anywhere on the preview site?

It's in another patch. FWIW, I've added the section to the preview, but
most of the changes from my Core-Gadget patch are not there yet.

> http://codereview.appspot.com/157078/diff/1/3
> File Social-Gadget.xml (right):

> http://codereview.appspot.com/157078/diff/1/3#newcode57
> Social-Gadget.xml:57: <t hangText="Parameters">This method takes a
single
> parameter, which is a JavaScript object representing the parameters
defined by
> the <eref target="Social-API-Server.xml#People.get">People service's
get
> method</eref>.</t>
> The eref, used many places, has changed. Maybe you wanted:
> #People-Service-GetPerson

yup - fixed.


http://codereview.appspot.com/157078
Reply all
Reply to author
Forward
0 new messages