Help needed - jQuery 3.6

2 views
Skip to first unread message

Tom Morris

unread,
Apr 6, 2021, 12:55:45 AM4/6/21
to openref...@googlegroups.com
I've resurrected and rebased my jQuery 3.5.1 branch from August and think it's getting close, but could use some help. After rebasing on the current master and updating to jQuery 3.6.0 and jQuery Migrate 3.3,2, I started working through the test failures. 

HUGE thanks to everyone who worked to put all the front end tests in place. That provides a significant safety net. Starting with 53 test failures, representing a half dozen unique bugs, we're now down to two test failures representing (likely) a single bug.

There are two things we could use help with:
- fixing the last bug identified by the test coverage
- finding all the other bugs for which we we don't have test coverage

What do folks think about where this should land when complete? Should we target it for OpenRefine 3.5 (soon, this quarter) or push it to 3.6?

Tom

Antonin Delpeuch (lists)

unread,
Apr 6, 2021, 2:27:38 AM4/6/21
to openref...@googlegroups.com
Great!

Given the scale of this update, I'd say we should not include it in 3.5.
Even if the new integration test suite helps catch some bugs, there
might be more remaining.

Also 3.5 is really overdue now, so I think the priority should be to get
it out the door as safely as possible (IMHO it was already a fairly big
risk to update Jetty).

Antonin

On 06/04/2021 06:55, Tom Morris wrote:
> I've resurrected and rebased my jQuery 3.5.1 branch
> <https://github.com/OpenRefine/OpenRefine/pull/3087> from August and
> think it's getting close, but could use some help. After rebasing on the
> current master and updating to jQuery 3.6.0 and jQuery Migrate 3.3,2, I
> started working through the test failures. 
>
> HUGE thanks to everyone who worked to put all the front end tests in
> place. That provides a significant safety net. Starting with 53 test
> failures, representing a half dozen unique bugs, we're now down to two
> test failures representing (likely) a single bug.
>
> There are two things we could use help with:
> - fixing the last bug identified by the test coverage
> <https://dashboard.cypress.io/projects/s5du3k/>
> - finding all the other bugs for which we we don't have test coverage
>
> What do folks think about where this should land when complete? Should
> we target it for OpenRefine 3.5 (soon, this quarter) or push it to 3.6?
>
> Tom
>
> --
> You received this message because you are subscribed to the Google
> Groups "OpenRefine Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to openrefine-de...@googlegroups.com
> <mailto:openrefine-de...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/openrefine-dev/CAE9vqEG6kLBOroVuBWn%2BipcngmVFodcH8htF5GPMSTYpeG_Cjw%40mail.gmail.com
> <https://groups.google.com/d/msgid/openrefine-dev/CAE9vqEG6kLBOroVuBWn%2BipcngmVFodcH8htF5GPMSTYpeG_Cjw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

Reply all
Reply to author
Forward
0 new messages