Build is broken - please fix it

[Tom Morris]

Hi Thad,

I've reverted your commit: f7cece6103d284b705c4a258830549a041691306

which broke the build: https://github.com/OpenRefine/OpenRefine/runs/1348346184

Please don't commit to master without creating a pull request for review.

If you've got your default git remote (ie origin) pointing to the main repo, please switch it to point to your personal fork to make it less likely that things like this happen.

Thanks,

Tom

[Thad Guidry]

Thanks Tom,

Yes, was going to fix this also (thanks VSCode!!)...got tied up in a phone call for last few hours.

Thad

https://www.linkedin.com/in/thadguidry/

[Thad Guidry]

Tom and devs,

Let's change this setting so that we include Administrators as well for Master branch protection (in case their IDE's screw up like mine did again for the 3rd time this year)

https://github.com/OpenRefine/OpenRefine/settings/branch_protection_rules/1264528

Include Administrators

It looks like it may/maynot affect Weblate ?

Thad

https://www.linkedin.com/in/thadguidry/

[Tom Morris]

Sorry for the mismatched subject & body. I decided to fix it myself rather than wait.

Can you confirm that you are pushing to https://github.com/thadguidry/OpenRefine/ and not https://github.com/OpenRefine/OpenRefine/ ? When I see new branches being created such as https://github.com/OpenRefine/OpenRefine/tree/fixReinterpretDocs it makes me suspicious that you've got the wrong remote configured.

Having the admin override for merging is actually useful for things like reviews with changes requested which have been addressed by the author, but the reviewer hasn't re-reviewed. While we could lock things down completely, it'd make committers' lives more difficult and slow down reviews, so I'd rather avoid it if there are less draconian solutions like fixing your git config.

Tom

[Thad Guidry]

Yes, I am always pushing to /thadguidry/OpenRefine

But I had to reinstall VSCode Insiders to get some support for a few newer things I'm needing on other projects and pulled in my older config for analyzing the OpenRefine Spark prototype branch.  (yes, my Windows system is in a sorry state and I need to spend a full 1/2 day putting things back the way I really want and need them! So sorry, yes, this is my fault, and know entirely what to do and how it should be setup...it's just my forgetfulness that crept in this time, that's all Tom)

Thad

https://www.linkedin.com/in/thadguidry/

[Antonin Delpeuch (lists)]

If accidentally pushing to master is a problem, I think we should just
put you in the group of normal contributors, so that the master branch
is protected for you. That should not prevent you from helping at the
administrative level in the project generally speaking.

Best,
Antonin

> --
> You received this message because you are subscribed to the Google
> Groups "OpenRefine Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to openrefine-de...@googlegroups.com
> <mailto:openrefine-de...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/openrefine-dev/CAChbWaMQ_PgYWkevhRSOVtuONU3aQ-0Qu21FsDWOvAKa3uQMSw%40mail.gmail.com
> <https://groups.google.com/d/msgid/openrefine-dev/CAChbWaMQ_PgYWkevhRSOVtuONU3aQ-0Qu21FsDWOvAKa3uQMSw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

[Thad Guidry]

Sure, let's do that.  I also thought the same thing.

Thad

https://www.linkedin.com/in/thadguidry/

To unsubscribe from this group and stop receiving emails from it, send an email to openrefine-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/0e1765d5-b3e3-bee7-cd5e-32ba25a38c6b%40antonin.delpeuch.eu.

[Antonin Delpeuch (lists)]

Ok, I have changed that. If you encounter any area where this new set up
does not work for you let me know, it should be possible to add custom
permissions where needed.

Antonin

> > <mailto:tfmo...@gmail.com <mailto:tfmo...@gmail.com>>> wrote:
> >
> >     Sorry for the mismatched subject & body. I decided to fix it
> myself
> >     rather than wait.
> >
> >     Can you confirm that you are pushing
> >     to https://github.com/thadguidry/OpenRefine/ and
> >     not https://github.com/OpenRefine/OpenRefine/ ? When I see new
> >     branches being created such
> >   
>  as https://github.com/OpenRefine/OpenRefine/tree/fixReinterpretDocs
> >     it makes me suspicious that you've got the wrong remote
> configured.
> >
> >     Having the admin override for merging is actually useful for
> things
> >     like reviews with changes requested which have been addressed
> by the
> >     author, but the reviewer hasn't re-reviewed. While we could lock
> >     things down completely, it'd make committers' lives more difficult
> >     and slow down reviews, so I'd rather avoid it if there are less
> >     draconian solutions like fixing your git config.
> >
> >     Tom
> >
> >     On Tue, Nov 3, 2020 at 3:38 PM Thad Guidry
> <thadg...@gmail.com <mailto:thadg...@gmail.com>

> >     <mailto:thadg...@gmail.com <mailto:thadg...@gmail.com>>>

> wrote:
> >
> >         Tom and devs,
> >
> >         Let's change this setting so that we include Administrators as
> >         well for Master branch protection (in case their IDE's
> screw up
> >         like mine did again for the 3rd time this year)
> >       
>  https://github.com/OpenRefine/OpenRefine/settings/branch_protection_rules/1264528
> >
> >         Include Administrators
> >
> >         It looks like it may/maynot affect Weblate ?
> >
> >         Thad
> >         https://www.linkedin.com/in/thadguidry/
> >
> >
> >         On Tue, Nov 3, 2020 at 2:32 PM Thad Guidry
> <thadg...@gmail.com <mailto:thadg...@gmail.com>

> >         <mailto:thadg...@gmail.com

> <mailto:thadg...@gmail.com>>> wrote:
> >
> >             Thanks Tom,
> >
> >             Yes, was going to fix this also (thanks
> VSCode!!)...got tied
> >             up in a phone call for last few hours.
> >
> >             Thad
> >             https://www.linkedin.com/in/thadguidry/
> >
> >
> >             On Tue, Nov 3, 2020 at 2:04 PM Tom Morris
> >             <tfmo...@gmail.com <mailto:tfmo...@gmail.com>

> <mailto:tfmo...@gmail.com <mailto:tfmo...@gmail.com>>> wrote:
> >
> >                 Hi Thad,
> >
> >                 I've reverted your
> >                 commit: f7cece6103d284b705c4a258830549a041691306
> >                 which broke the
> >               
>  build: https://github.com/OpenRefine/OpenRefine/runs/1348346184
> >
> >                 Please don't commit to master without creating a pull
> >                 request for review.
> >
> >                 If you've got your default git remote (ie origin)
> >                 pointing to the main repo, please switch it to
> point to
> >                 your personal fork to make it less likely that things
> >                 like this happen.
> >
> >                 Thanks,
> >                 Tom
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "OpenRefine Development" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> > an email to openrefine-de...@googlegroups.com

> <mailto:openrefine-dev%2Bunsu...@googlegroups.com>
> > <mailto:openrefine-de...@googlegroups.com
> <mailto:openrefine-dev%2Bunsu...@googlegroups.com>>.

> > To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/openrefine-dev/CAChbWaMQ_PgYWkevhRSOVtuONU3aQ-0Qu21FsDWOvAKa3uQMSw%40mail.gmail.com
> >
> <https://groups.google.com/d/msgid/openrefine-dev/CAChbWaMQ_PgYWkevhRSOVtuONU3aQ-0Qu21FsDWOvAKa3uQMSw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "OpenRefine Development" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to openrefine-de...@googlegroups.com

> <mailto:openrefine-dev%2Bunsu...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/openrefine-dev/0e1765d5-b3e3-bee7-cd5e-32ba25a38c6b%40antonin.delpeuch.eu.

>
> --
> You received this message because you are subscribed to the Google
> Groups "OpenRefine Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to openrefine-de...@googlegroups.com
> <mailto:openrefine-de...@googlegroups.com>.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/openrefine-dev/CAChbWaN_nAFY0HkYVJYL5k4h6%3D2LrJf%2BGBOW-4o27mAHf405ew%40mail.gmail.com
> <https://groups.google.com/d/msgid/openrefine-dev/CAChbWaN_nAFY0HkYVJYL5k4h6%3D2LrJf%2BGBOW-4o27mAHf405ew%40mail.gmail.com?utm_medium=email&utm_source=footer>.