Testing 3.6 on Windows 11 and the application termination with CTRL-C

[Thad Guidry]

I have a sneaky suspicion that we should be logging out when we detected a CTRL-C from the user.

The exit code in Windows 11 is a force close by user, and not necessarily indicative of a graceful shutdown as we had before and project saving successfully behind the scenes is no longer being shown which worries me a bit.

Any thoughts?

Thad

https://www.linkedin.com/in/thadguidry/

https://calendly.com/thadguidry/

[Thad Guidry]

Hmm, it seems the default on Windows 11 is now "Let Windows decide" which default terminal application to use.

Since 3.6 is or will be new on folks system, and on Windows they have to approve to run it from the Run dialog box...

It seems that this setting then takes effect and might have implications for our Windows 11 users?

Thad

https://www.linkedin.com/in/thadguidry/

https://calendly.com/thadguidry/

[Antonin Delpeuch (lists)]

Hi Thad,

If I remember correctly, pressing CTRL-C in the Windows terminal did use to close OpenRefine properly.

Are you saying that this has changed with OpenRefine 3.6.0?

Or does this rather depend on the Windows version?

Thanks,

Antonin

--
You received this message because you are subscribed to the Google Groups "OpenRefine Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openrefine-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/CAChbWaMqggE%2BG_fMKXYa%2BbRjZQ9Sr4gUQMxgmo%2BNF3OehkuukA%40mail.gmail.com.

[Thad Guidry]

I don’t know quite yet since I need to test also on Windows 10 to see differences.

But would be good to know from other folks who might have tested on Windows.

To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/44f34ce3-cc51-1a9a-9a18-cccee89f5790%40antonin.delpeuch.eu.

--

[Thad Guidry]

OK, I just tested and changes are only on the OS side because...

Windows 11 pushed out changes last month to Insiders to change the default terminal application to be Windows Terminal, rather than Command Prompt (Windows Console Host)
This began to happen in Windows 11 Insider Preview Build 22621.436 and Build 22622.436

So we'll need a strategy to deal with this likely by next spring when this hits the general public.

1. Find a better way to detect the CTRL-C shutdown signal in Windows Terminal (and not only Windows Console Host/Command Prompt)

2. Alternatively, change the way that OpenRefine runs on Windows and have a dedicated app launcher with all the bells and whistles and WinUI3 support!!

I think working towards #2 is the ideal solution and we are nearly there since we now have the  OpenRefine/openrefine-tauri: Prototype of a launcher for OpenRefine built with Tauri (github.com)   that just needs a bit more work to finish it up. See https://github.com/OpenRefine/OpenRefine/issues/3221

Digitally signing for Windows https://github.com/OpenRefine/OpenRefine/issues/3003

And then wrapping the launcher and files into a better installer experience in issue https://github.com/OpenRefine/OpenRefine/issues/3224

So I think with a bit of work on those 3 issues we should be future forward for Windows 11 compatibility fully.

Thad

https://www.linkedin.com/in/thadguidry/

https://calendly.com/thadguidry/

[Thad Guidry]

Hmm, OK, I think there might be more to this, since I've done even more testing.

I've opened an issue with Microsoft's Windows Terminal here to fully describe the scenario I am seeing: https://github.com/microsoft/terminal/issues/13582

Thad

https://www.linkedin.com/in/thadguidry/

https://calendly.com/thadguidry/

[Antoine Beaubien]

Are you sure that the CTRL-C shutdown signal in the Windows Console Host/Command Prompt prevent a normal saving and exiting on Windows 10? Because that one thing I understand from your comment. Did I understand you correctly?

Because, one user who did testing a few weeks ago pretended otherwise.

Regards, 

   Antoine

[Thad Guidry]

Antoine,

CTRL-C shutdown signal in the Windows Console Host/Command Prompt does not prevent a normal saving and exiting of OpenRefine on Windows 10.

This is a specific issue only with Windows Terminal where the shell setting is PowerShell.

My issue opened with Microsoft Terminal repo describes the contexts well enough I think.

We'll hear from them likely by the end of Monday and can take a course of action after that.

Thad

https://www.linkedin.com/in/thadguidry/

https://calendly.com/thadguidry/

To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/8a64c890-1762-497f-bf76-1315efca188fn%40googlegroups.com.