Introduction and help with issue #2071

55 views
Skip to first unread message

Vani Gupta

unread,
Apr 8, 2022, 9:09:56 PM4/8/22
to OpenRefine Development
Hi I am Vani! I am a freshman majoring in computer science and I am working on the issue TSV export escapes double quotes (") unnecessarily ". When I add a cell with double quotes however I see no changes or errors while exporting to TSV. I am not able to understand how to reproduce this error.
I added comme "braille mental" and I see this exactly when I upload and create the project on openrefine. Can someone help me understand the issue ?
Thanks
Screenshot 2022-04-08 at 9.02.34 PM.png

Antonin Delpeuch (lists)

unread,
Apr 10, 2022, 2:51:13 AM4/10/22
to openref...@googlegroups.com

Hi Vani,

As the issue mentions it is about TSV export, not TSV import. Looking at your screenshot, it seems that you are experimenting with the importer instead.

Best,

Antonin

--
You received this message because you are subscribed to the Google Groups "OpenRefine Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openrefine-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/44554a82-4bae-418f-8e79-ac88fd756740n%40googlegroups.com.

Vani Gupta

unread,
Apr 11, 2022, 9:54:07 AM4/11/22
to OpenRefine Development
Hi Antonin! Thanks for pointing that out. I have tried exporting the values in tsv and I had some doubts
a) the feature request is to escape (",`,') ie. append these characters with " in a field value.
However, the issue heading on github is "tsv export escapes the double quotes unnecesarily". Does this feature request mean the same thing in both places? I was a little confused with the wording
b) Do you think I should change code in CSV exporter.java file or should I make another TSV exporter file.

Antonin Delpeuch (lists)

unread,
Apr 12, 2022, 3:04:50 AM4/12/22
to openref...@googlegroups.com

Hi Vani,

a) the feature request is to avoid escaping of some characters in some situations, as the title suggests. Is there a particular sentence in the body of the issue which makes you think otherwise?

b) the changes should be made to the existing exporter.

Thanks,

Antonin

Vani Gupta

unread,
Apr 12, 2022, 7:46:45 PM4/12/22
to OpenRefine Development
Okay got it! thank you so much!!

Vani Gupta

unread,
Apr 14, 2022, 4:01:53 PM4/14/22
to OpenRefine Development
Hi 

I made a pull request yesterday but I forgot to write tests so I committed again but I am not able to open a pull request again for my second pull request so do I need to make another branch for the second commit?

Thanks,
Vani

Babi B

unread,
Apr 21, 2022, 6:38:34 AM4/21/22
to OpenRefine Development
You don't need to create a new branch. Push the new work you have done and it'll synchronize with the current PR
Reply all
Reply to author
Forward
0 new messages