Questions about the build workflow, github actions not triggered

[Florian Giroud]

Antonin, Kush, I am curious about our CI

My recent pushes to master have not triggered any Cypress run for the "snapshot_release"
That's problematic

But few days ago, some pushes have triggered a snapshot release
See in the github actions panel

Did something changed ?
Or is it because I used "'squash and merge" ?

Thanks in advance
Best,
- Florian

[Kush Trivedi]

Hi Florian,

Thanks for noticing, looking into it looks like a recent PR for paths-ignore has broken the workflow. Taking from the github-actions doc, when we only need to exclude the paths we should use `paths-ignore` rather than negation sign, and if we are using positive and negative patterns then we should define a positive matching pattern too https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#excluding-paths.

I will make the fix for it quickly.

Regards,

Kush

--
You received this message because you are subscribed to the Google Groups "OpenRefine Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openrefine-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/9e63f87e-0a28-49d7-9d62-0168156661c3n%40googlegroups.com.

[Thad Guidry]

But we don't want snapshots being generated when only the files under /docs have changed.

Snapshot releases should only be generated on source code changes I would think (maybe we should add those positive also)?

So are not the "paths" with negative and positive patterns the right approach?

Thad

https://www.linkedin.com/in/thadguidry/

https://calendly.com/thadguidry/

To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/CACW7oBwLTZNU5v%3DXFmd6Rdwr2P_JDXUrwqdjkWqgC4EcEK7RXw%40mail.gmail.com.

[Kush Trivedi]

Hi Thad,

For ignoring a directory, github has 'paths-ignore' but however if you want to choose negative and positive, then you also need to explicitly specify what paths you need as positive and negative. In this case, when we only want to ignore 'docs' directory we should have gone ahead with paths-ignore. Thats what I was able to get from what github-actions docs specified.

Also, Github workflow for snapshot is restored now.

Regards,

Kush

To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/CAChbWaNhN66FAnfcM4-bpWvNE9iPgobuvuAUM2gy7ercO6CFag%40mail.gmail.com.