[google-refine] r2174 committed - Make tab size the standard value of 8 spaces.

[google...@googlecode.com]

Revision: 2174
Author: tfmo...@gmail.com
Date: Tue Aug 2 13:54:23 2011
Log: Make tab size the standard value of 8 spaces.
http://code.google.com/p/google-refine/source/detail?r=2174

Modified:
/trunk/IDEs/eclipse/Refine.style.xml
/trunk/broker/appengine/.settings/org.eclipse.jdt.core.prefs
/trunk/broker/core/.settings/org.eclipse.jdt.core.prefs
/trunk/extensions/jython/.settings/org.eclipse.jdt.core.prefs
/trunk/extensions/sample/.settings/org.eclipse.jdt.core.prefs
/trunk/server/.settings/org.eclipse.jdt.core.prefs

=======================================
--- /trunk/IDEs/eclipse/Refine.style.xml Wed Sep 22 15:55:28 2010
+++ /trunk/IDEs/eclipse/Refine.style.xml Tue Aug 2 13:54:23 2011
@@ -21,7 +21,7 @@
<setting
id="org.eclipse.jdt.core.formatter.format_guardian_clause_on_one_line"
value="false"/>
<setting
id="org.eclipse.jdt.core.formatter.comment.insert_new_line_before_root_tags"
value="insert"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_for"
value="insert"/>
-<setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="4"/>
+<setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="8"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_space_after_opening_angle_bracket_in_type_parameters"
value="do not insert"/>
<setting id="org.eclipse.jdt.core.formatter.blank_lines_before_imports"
value="1"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_case"
value="insert"/>
=======================================
--- /trunk/broker/appengine/.settings/org.eclipse.jdt.core.prefs Mon Sep 27
15:11:38 2010
+++ /trunk/broker/appengine/.settings/org.eclipse.jdt.core.prefs Tue Aug 2
13:54:23 2011
@@ -1,5 +1,15 @@
-#Mon Sep 27 15:02:14 PDT 2010
+#Tue Aug 02 16:47:21 EDT 2011
eclipse.preferences.version=1
+org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.6
+org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
+org.eclipse.jdt.core.compiler.compliance=1.6
+org.eclipse.jdt.core.compiler.debug.lineNumber=generate
+org.eclipse.jdt.core.compiler.debug.localVariable=generate
+org.eclipse.jdt.core.compiler.debug.sourceFile=generate
+org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
+org.eclipse.jdt.core.compiler.source=1.6
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

org.eclipse.jdt.core.formatter.alignment_for_arguments_in_allocation_expression=16
org.eclipse.jdt.core.formatter.alignment_for_arguments_in_annotation=0
@@ -77,7 +87,7 @@
org.eclipse.jdt.core.formatter.indent_statements_compare_to_body=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true
-org.eclipse.jdt.core.formatter.indentation.size=4
+org.eclipse.jdt.core.formatter.indentation.size=8

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_member=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter=do
not insert
=======================================
--- /trunk/broker/core/.settings/org.eclipse.jdt.core.prefs Mon Sep 27
15:11:38 2010
+++ /trunk/broker/core/.settings/org.eclipse.jdt.core.prefs Tue Aug 2
13:54:23 2011
@@ -1,4 +1,4 @@
-#Mon Sep 27 15:02:27 PDT 2010
+#Tue Aug 02 16:47:20 EDT 2011
eclipse.preferences.version=1
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

org.eclipse.jdt.core.formatter.alignment_for_arguments_in_allocation_expression=16
@@ -77,7 +77,7 @@
org.eclipse.jdt.core.formatter.indent_statements_compare_to_body=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true
-org.eclipse.jdt.core.formatter.indentation.size=4
+org.eclipse.jdt.core.formatter.indentation.size=8

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_member=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter=do
not insert
=======================================
--- /trunk/extensions/jython/.settings/org.eclipse.jdt.core.prefs Mon Sep
27 15:11:38 2010
+++ /trunk/extensions/jython/.settings/org.eclipse.jdt.core.prefs Tue Aug
2 13:54:23 2011
@@ -1,4 +1,4 @@
-#Mon Sep 27 15:02:39 PDT 2010
+#Tue Aug 02 16:47:21 EDT 2011
eclipse.preferences.version=1
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

org.eclipse.jdt.core.formatter.alignment_for_arguments_in_allocation_expression=16
@@ -77,7 +77,7 @@
org.eclipse.jdt.core.formatter.indent_statements_compare_to_body=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true
-org.eclipse.jdt.core.formatter.indentation.size=4
+org.eclipse.jdt.core.formatter.indentation.size=8

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_member=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter=do
not insert
=======================================
--- /trunk/extensions/sample/.settings/org.eclipse.jdt.core.prefs Fri Oct
15 14:42:49 2010
+++ /trunk/extensions/sample/.settings/org.eclipse.jdt.core.prefs Tue Aug
2 13:54:23 2011
@@ -1,4 +1,4 @@
-#Fri Oct 15 21:39:54 GMT 2010
+#Tue Aug 02 16:47:21 EDT 2011
eclipse.preferences.version=1
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.6
@@ -83,7 +83,7 @@
org.eclipse.jdt.core.formatter.indent_statements_compare_to_body=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true
-org.eclipse.jdt.core.formatter.indentation.size=4
+org.eclipse.jdt.core.formatter.indentation.size=8

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_member=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter=do
not insert
=======================================
--- /trunk/server/.settings/org.eclipse.jdt.core.prefs Mon Sep 27 15:11:38
2010
+++ /trunk/server/.settings/org.eclipse.jdt.core.prefs Tue Aug 2 13:54:23
2011
@@ -1,4 +1,4 @@
-#Mon Sep 27 15:02:58 PDT 2010
+#Tue Aug 02 16:47:21 EDT 2011
eclipse.preferences.version=1
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false

org.eclipse.jdt.core.formatter.alignment_for_arguments_in_allocation_expression=16
@@ -77,7 +77,7 @@
org.eclipse.jdt.core.formatter.indent_statements_compare_to_body=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases=true

org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true
-org.eclipse.jdt.core.formatter.indentation.size=4
+org.eclipse.jdt.core.formatter.indentation.size=8

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_member=insert

org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter=do
not insert

[Stefano Mazzocchi]

Please revert. 

8 spaces for a tab makes the code unreadable. It might be standard for C/C++ but 4 is the usual size for java code.

--
Stefano Mazzocchi  <stef...@google.com>
Software Engineer, Google Inc.

[David Huynh]

I think his intention is to use spaces for indentation and so any tab would stand out.

David

[Tom Morris]

Actually the Refine indentation policy has been "spaces only" for
ages. I'm just doing the last of the cleanups.

Using 8 space tabs has the side benefit of making code with "mixed
tabs and spaces" stick out more, but it's also the standard across the
bulk of text processing utilities, not just C/C++.

As of right now, there are no tabs being used for indentation in the
code base. I think it would be a good idea to keep it that way.

Tom

[Stefano Mazzocchi]

On Tue, Aug 2, 2011 at 8:27 PM, Tom Morris <tfmo...@gmail.com> wrote:

Actually the Refine indentation policy has been "spaces only" for
ages.  I'm just doing the last of the cleanups.

Using 8 space tabs has the side benefit of making code with "mixed
tabs and spaces" stick out more, but it's also the standard across the
bulk of text processing utilities, not just C/C++.

As of right now, there are no tabs being used for indentation in the
code base.  I think it would be a good idea to keep it that way.

Oh, I see, 8spaces tabs to make it more evident when they are there. Good thinking, I like that idea and sorry for not having understood your intention.

/me crawls back into his corner