KiCad footprint importer ..

[vespaman]

Hi guys,

I would like to suggest that PR1758 should be included whenever possible. I guess it has fallen between chairs, but seeing as the current KiCad importer does not work with every footprint file (as has been reported here a couple of times), and 1758 mitigates this, also it is a rather clean PR.

I see there's also a larger KiCad PR1833, and maybe this is why 1758 has been put on hold. While 1833 looks very interesting to me, I guess it might need more testing.

  - Micael

[Toby Dickenson]

From a personal point of view, PR 1758 would have been merged ages ago if it had unit tests.

This should have unit tests that prove the code still works with the old file format, tests for this new file format, and tests for some error cases. This PR changes the parser to match parentheses, but what happens if the closing parenthesis is missing?

This isnt really a statement of policy, but rather a statement about what would make my review easier. Reviewing the java code construction is a self-contained task, and if I can satisfy myself that the PR is good I can merge quite quickly. But if I can't review the PR without first educating myself about Kicad's file formats, even if the code is good, the PR will have to wait until I need that feature myself.

Toby

--
You received this message because you are subscribed to the Google Groups "OpenPnP" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openpnp+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/openpnp/3bb6f1b4-c663-41f0-b929-5f187ddae3b9n%40googlegroups.com.