Release Candidate 5

[Jaisen Mathai]

Let's hope this is the final release :).

I'll let anyone who's interested test this over the weekend and unless there are blocking issues will release next week.

https://github.com/photo/frontend/releases/tag/4.0.0-rc5

[Hubert Figuière]

You downgraded the version number?

Hub

[Jaisen Mathai]

Ugh. Typo.

--
You received this message because you are subscribed to the Google Groups "OpenPhoto" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openphoto+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
-- Snet form my mobl phoone

[Jay Sitter]

Thanks!

[Robert Kleinschmager]

first look to the release is good,

fresh install and some use cases worked very well.

Still some features from rc3 are missing - hope you have tracked this somehow

cheers

Robert

[Jaisen Mathai]

> Still some features from rc3 are missing - hope you have tracked this somehow

Can you list which features?

--

[Robert Kleinschmager]

sorry, have no list.

missing my favorite feature: "Invite Uploaders" introduced by commit https://github.com/photo/frontend/commit/d0ddf9f4fb5add537eb29c347b38ce7f476d6396

this and many other changes (f.e. fix for issue https://github.com/photo/frontend/issues/1453) are now in rc3, but not merged into rc5

do you need help to merge each rc3 commit into rc5 .. step by step

[Jaisen Mathai]

Gotcha. RC3 was a large merge which wasn't slotted for this release. Operator error. If you look at RC2 -> RC4 that's what RC3 was supposed to be.

[Robert Kleinschmager]

so what will happen to all the changed, which are in rc3 - any plans?

[Hubert Figuière]

On 25/06/14 05:27 AM, Robert Kleinschmager wrote:
> so what will happen to all the changed, which are in rc3 - any plans?

If anything this branch should be renamed.


Hub

[Jaisen Mathai]

It'll go to the next major version release.

--
You received this message because you are subscribed to the Google Groups "OpenPhoto" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openphoto+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

[Hubert Figuière]

On 26/06/14 10:16 PM, Jaisen Mathai wrote:
> It'll go to the next major version release.

So you can rename it now so that people stop asking what's the deal. Get
it out of the way. That's the only quick fix.

Then you can work and proper branching.

Hub

[Vašek Stodůlka]

Dne středa, 18. června 2014 22:18:42 UTC+2 jmathai napsal(a):

Let's hope this is the final release :).

I'll let anyone who's interested test this over the weekend and unless there are blocking issues will release next week.

https://github.com/photo/frontend/releases/tag/4.0.0-rc5

Hi.

I have upgraded to 4.0.2 (I'm on branch master) and didn't see any of my photos. Going back and forth in git, I have found, that patch 3de05532898afd4b2add1b7572e25b7129d6ae83 breaks things. Fortunately it's a very simple patch, setting mode=prod from mode=dev. So I came back to HEAD, created /src/configs/override.ini and put [site] mode=dev in that file (as mentioned in #1495) and have my photos back.

Should it work this way?

--VS



[Jaisen Mathai]

Do you get any errors in your error log?

[Vašek Stodůlka]

Dne čtvrtek, 3. července 2014 19:55:57 UTC+2 jmathai napsal(a):

Do you get any errors in your error log?

No, only [Thu Jul 03 01:13:09 2014] [error] [client 212.79.106.8] PHP Notice:  Undefined variable: key in /srv/www/openphoto/src/libraries/controllers/AssetsController.php on line 53, referer: http://fotky.stodulkovi.cz/p/u1/token-5208d65a28

But I'm pretty sure, that have seen this warning also before upgrade.

I don't know, where trovebox is logging - only through apache? Now I'm in state, where I can test this (possible) bug - switching to "prod" is simple and I can't see photos there. If you send me what you want me to do, I'll report back. (My setup is pretty standard Debian 7 with shipped apache 2.2.22, the only glitch is, that I have src/html/photos symlink to NFS, but this is not the case of failure, NFS works well.)

Regards,

--VS

[Jaisen Mathai]

Do you have a public link to your site? Is the issue related to this bug? https://github.com/photo/frontend/issues/1267