Reverting breaking changes

[kpalkowska]

Hi all,

On the one of Team Parrot Retrospective meeting, we talked about quite a lot of broken build notifications on our CI. In order to avoid long-term failures on #build channel and unknown current status of work on fixes, we strongly recommend every developer who expects he may not be able to fix Sonar/tests/build issues within a working day to revert the changes. The continuous failures may cause some confusion and make it difficult to track the current build status. Reverting breaking changes will help us to fix that problem. I've already updated Contribution Guide and Code Submission Conventions to include that suggestion.

Feel free to let me know what do you think about it.

Regards,

Klaudia

[Nikodem Graczewski]

Hi all,

how do we want to make sure that the changes are reverted? Should we choose a policeman (switched every Sprint/week) to ensure we're not leaving any builds broken?

Best regards,

Nikodem Graczewski

Software Developer

ngrac...@soldevelo.com

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/93df1971-4689-4983-baef-4e4359f45e8d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

[Łukasz Lewczyński]

Hi all,

I have only one concern about this idea. I remember that sometimes there were situations where a build failed because of sonar and a developer reverted changes but build still failed because sonar found other issues that were not directly related with the developer changes. The most often was about the test coverage for missing branches in classes - sonar requires about 65% of coverage. How would we like to handle those situations? I mean situations where a developer revers changes but builds still fail.

Łukasz Lewczyński
Software Developer
llewc...@soldevelo.com

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAGOM9mUND4szx_rrph6Nb8BCfCy3E-T%2BeKA-YLaZe7WMUnYpTA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[Klaudia Pałkowska]

Hi,

Nikodem - I think that everyone is aware that we should keep an eye on the build channel, especially after committing some changes. I'm not sure whether we need a special guard. Moreover, everyone can start work at the different time so it would be difficult to track when every developer ends his/her working day and have to revert his/her breaking changes. But if you feel it's necessary, we can try.

What do you suggest to avoid the situations described by you, Łukasz? I would say they are quite rare, so we can just leave it and try to fix Sonar issues ASAP.

Best,

Klaudia

--

Klaudia Pałkowska
Junior Software Developer 
kpalk...@soldevelo.com

SolDevelo Sp. z o. o. [LLC] 
Office: +48 58 782 45 40 / Fax: +48 58 782 45 41Al. Zwycięstwa 96/9881-451, Gdynia 
http://www.soldevelo.com

Place of registration: Regional Court for the City of GdanskKRS: 0000332728, TAX ID: PL5862240331, REGON: 220828585,Share capital: 60,000.00 PLN