--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53wMMq2WP0M8vPwktBKi3UAUdTo47z7LxJ8U%2Bou9mC550g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Paweł Albecki
Software Developer
palb...@soldevelo.com
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAJzpf%3DODU8XH%3DqRvwUQCuxQDpttiBxNv9fQ6pDmF0aJoQpUBQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53yOBnxd43v0pOM-p0uQPj9ZTEUnOJS%2BvBzrnGbKVaodWA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53z8zNzX1ky3X85_BEUsRx0dEpQQ-W63bCAG9Q6x_3ZUGg%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/202a0dc7-17d5-473e-84f5-c01b379766b0%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAHq-FDPR%3DDVwsk_Ve93%2BVCfsReR2GUwZhk78HTdXimp%3DA56yeQ%40mail.gmail.com.
Paweł Gesek
Technical Project Manager
pge...@soldevelo.com / +48 690 020 875
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu1b3RKRhTAwiLDgVwPGVvbZNY%3D%3D51A__7tuPeD3iV3Mjg%40mail.gmail.com.
Paweł Albecki
Software Developer
palb...@soldevelo.com
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/8aa75aef-c803-45ef-85e3-e78468f0f61a%40googlegroups.com.
Hi,I've restricted Sonar quality gate to fail on any code smell, to get it "work" on UI I had to disable checks for:
* trailing spaces - because of problems with License Header, we have ticket for that: OLMIS-3964,* using strict in JS files - we are using it in every JS file,* to many parameters in JS functions - the problem is with injecting more than 7 services or other parameters to controllers etc. which we can't avoid, but we are also loosing check for number of parameters in regular functions,* function names should use cammelCase - we have functions like ProofOfDeliveryRepository or FacilityListController which are starting with upper case letter, we could rename them and keep original names while declaring those components (angular.module(some-module).controller('FacilityListController', facilityListController))Any opinions on this? Should we keep disabled checks or somehow resolve some them?Best Regards,
Mateusz
On Thu, Feb 22, 2018 at 9:12 PM, brandon.bowersox-johnson <brandon.bowersox-johnson@villagereach.org> wrote:+1 for Paweł Gesek's comments:--
- If we have rules we do not intend to follow, we should disable those.
- When it comes to Code Smells and Sonar alerts, we should not sacrifice quality to achieve deadlines. If we let a few months go by sacrificing quality or ignoring sonar alerts, we would have tons of code smells in there. At that point, we would have no memory of all those parts of the codebase we were working on. It's much cheaper to get alerts and fix it right away, hopefully within minutes after we write the code itself.
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/8aa75aef-c803-45ef-85e3-e78468f0f61a%40googlegroups.com.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAHq-FDP0P32TmUQvB2XqjQbZT8YMfo9SGkCvPHNbKm-a_0o%2BuA%40mail.gmail.com.
Hi Mateusz,
I think we should rethink point 3. If we have a controller that uses that many things it probably indicates that it is trying to do too many things. I would, perhaps, turn that check back on and see how it goes with the new code (I believe the old code wouldn't be caught unless we modify it, right?).
About point 4, this should be resolved once we get our hands on ES6 and JavaScript classes.
Best regards,
Nikodem
On Wed, Mar 7, 2018 at 1:45 PM, Mateusz Kwiatkowski <mkwiat...@soldevelo.com> wrote:
Hi,I've restricted Sonar quality gate to fail on any code smell, to get it "work" on UI I had to disable checks for:
* trailing spaces - because of problems with License Header, we have ticket for that: OLMIS-3964,* using strict in JS files - we are using it in every JS file,* to many parameters in JS functions - the problem is with injecting more than 7 services or other parameters to controllers etc. which we can't avoid, but we are also loosing check for number of parameters in regular functions,* function names should use cammelCase - we have functions like ProofOfDeliveryRepository or FacilityListController which are starting with upper case letter, we could rename them and keep original names while declaring those components (angular.module(some-module).controller('FacilityListController', facilityListController))Any opinions on this? Should we keep disabled checks or somehow resolve some them?Best Regards,
Mateusz
On Thu, Feb 22, 2018 at 9:12 PM, brandon.bowersox-johnson <brandon.bowe...@villagereach.org> wrote:
+1 for Paweł Gesek's comments:
- If we have rules we do not intend to follow, we should disable those.
- When it comes to Code Smells and Sonar alerts, we should not sacrifice quality to achieve deadlines. If we let a few months go by sacrificing quality or ignoring sonar alerts, we would have tons of code smells in there. At that point, we would have no memory of all those parts of the codebase we were working on. It's much cheaper to get alerts and fix it right away, hopefully within minutes after we write the code itself.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/8aa75aef-c803-45ef-85e3-e78468f0f61a%40googlegroups.com.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAHq-FDP0P32TmUQvB2XqjQbZT8YMfo9SGkCvPHNbKm-a_0o%2BuA%40mail.gmail.com.