--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/37e6e39d-bb17-45c6-8b04-d136de53dcc1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
As you said I opened up port 8500 and add check that service list in the migration test script is not empty. After those changes migration test failed so I thought that everything is okay but Pawel Albecki found out that this error was connected with javers rather than migrations.I think we need more demo data - each table should contain some data with all variations of some fields (if SQL field is related with java enum field, the SQL field should contain all possibilities of enum). Also I think we could create some integration test that verify our migrations. A good example is in the reference data service: migration test.Regards,Lukasz
On Wed, Mar 7, 2018 at 8:25 PM, <josh....@openlmis.org> wrote:
In the past couple weeks an issue surfaced that our automated database migration test job wasn't fully capturing migrations that weren't production ready. Could someone(s) summarize what the overall issue and steps taken to fix have been? I've seen some of this in Slack, however this is critical for our release so I'd prefer if we could get it written down here on the technical forum.
One of the minor things I've noticed is that we've opened up port 8500 (Consul's management port) to the Docker host in order for the migration tests to run - this is enough of a security concern that if we shipped this, we'd want to ensure we had documentation for how to not expose this port beyond the docker host. I don't want this issue to dominate this discussion, it's minor, however lets include here changes like this to make the tests run.
Finally it'd help if people expressed their confidence in the migrations we've written since Ref Distro v3.2.1. The automated tests, if working, would still be dependent on demo data, which in the last showcase it appeared we might need more. Are we in better shape? Similar shape?
Best,
Josh
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/37e6e39d-bb17-45c6-8b04-d136de53dcc1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/128cbbfb-e921-4dd2-a82e-f1e1e15c5dc8%40googlegroups.com.
Paweł Albecki
Software Developer
palb...@soldevelo.com
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAJzpfkwmqgbBx44QNkPqw9mtRwUBkTAaOuNXNk8%3DGvO6dz7DA%40mail.gmail.com.