new functionality: gml 3.2 and complex features

22 views
Skip to first unread message

Niels Charlier

unread,
Jul 20, 2018, 8:25:28 AM7/20/18
to OpenLayers Dev
Hello,

I have written two patches for open layers:
* support for GML 3.2
* support for parsing complex features
I was wondering if the community would be interested in me contributing these to the codebase.

The first one simply adds a whole new format, so it is a very safe addition.

The second one replaces an existing function: ol.format.GMLBase.prototype.readFeaturesInternal
however my implementation of this function is a generalisation of the current implementation,
and it is thus fully backwards compatible with how simple features are parsed now.
I don't know if there is some kind of testing mechanism in place to proof my changes don't break anything.

I could make one or two PRs on github, let me know i there is interest and what I need to do in order to get it approved, .

Kind Regards
Niels

Jeff McKenna

unread,
Jul 22, 2018, 2:02:35 PM7/22/18
to openlay...@googlegroups.com
(I am not a member of the OL development team)

Please go ahead with creating your pull requests; the OL development
team will be automatically notified of your pull request. 2 separate
pull requests might be a good plan.

-jeff

Niels Charlier

unread,
Aug 15, 2018, 10:31:36 AM8/15/18
to openlay...@googlegroups.com
Thanks. Unfortunately I had to combine them in one PR because the two
patches are interdependent and I can't do much about that (GML3.2 must
also support complex features). I have added test cases for all new
functionality.

I have noticed in the meantime however there was already an old PR for
GML3.2 support that never got approved :/

Kind Regards

Niels
Reply all
Reply to author
Forward
0 new messages