Drop all components from source tree except from openjp2

37 views
Skip to first unread message

Even Rouault

unread,
Apr 27, 2021, 12:03:18 PM4/27/21
to open...@googlegroups.com, antonin....@uclouvain.be
Hi,

it seems to me that besides openjp2, the openjpwl, openjp3d and openmj2
components are not in active use, and in particular they aren't built by
the continuous integration, hence they are broken. I see people issuing
pull requests to make them compile or fix security issues, but while
probing a bit about their interest, it seems those people just compile
them by habit (typically package maintainers) but not for personal use.

It seems to me the situation would be clearer (and that would save me
some github pinging) if we just drop those components from the source
tree (people might still reach them in older tags if needed)

I'm not sure what we should do with the openjpip component, which has a
stronger connection with openjp2. I've no use of it personally. It is
not built by the continuous integration either.

Thoughts ? (if someone doesn't agree with this proposal, then they'd
have to step up to review pull requests related to those components and
set up continuous integration for them ;-))

Even

--
http://www.spatialys.com
My software is free, but my time generally not.

Antonin Descampe

unread,
Apr 27, 2021, 2:33:27 PM4/27/21
to open...@googlegroups.com
Hi,

I support this proposal from Even: unless someone is willing to take care of the maintenance of these obsolete components, I would simply remove them from the source (while still available in the repo history).

Practically, and to give us a concrete timeline, if no answer is received by next Tuesday CoB (CEST), I suggest to proceed that way.

Cheers,

Antonin
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.spatialys.com%2F&data=04%7C01%7Cinfo%40openjpeg.org%7C670d0fbb3617459ba0ca08d90995f99b%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637551362006104936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fl9dCUT%2BfamvoDJOMBIQQA1vBNkXcjvoZkUPT5Hlm98%3D&reserved=0
> My software is free, but my time generally not.
>
> --
> You are subscribed to the mailing-list of the OpenJPEG project (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.openjpeg.org%2F&data=04%7C01%7Cinfo%40openjpeg.org%7C670d0fbb3617459ba0ca08d90995f99b%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637551362006104936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qsFZ5g58WGOv%2BSBiPkCA5hlGVHhVETyVdC8i2muqgx8%3D&reserved=0)
> To post: email to open...@googlegroups.com
> To unsubscribe: email to openjpeg+u...@googlegroups.com
> For more options: visit https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgroups.google.com%2Fgroup%2Fopenjpeg&data=04%7C01%7Cinfo%40openjpeg.org%7C670d0fbb3617459ba0ca08d90995f99b%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637551362006104936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cQscP3iRTJ5iHepIBB2i6IUzibB7934S60Sa3XGlcdo%3D&reserved=0
> OpenJPEG is mainly supported by : * UCL Image and Signal Processing Group (http://sites.uclouvain.be/ispgroup) * IntoPIX (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.intopix.com%2F&data=04%7C01%7Cinfo%40openjpeg.org%7C670d0fbb3617459ba0ca08d90995f99b%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637551362006104936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=N8IdejjHfnHJIO7xfCTKRmCkXrRLN2Lev5HcpWuApkk%3D&reserved=0)
> --- You received this message because you are subscribed to the Google Groups "OpenJPEG" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to openjpeg+u...@googlegroups.com.
> To view this discussion on the web visit https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fopenjpeg%2Fcfec5028-e90f-df52-ef83-45abd97aaccf%2540spatialys.com&data=04%7C01%7Cinfo%40openjpeg.org%7C670d0fbb3617459ba0ca08d90995f99b%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637551362006104936%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Iwp%2Fkm0BBgK%2BbThrLYMjClHd0yL4YwpPa6gS7AJjjfw%3D&reserved=0.

Mario Emmenlauer

unread,
Apr 27, 2021, 2:49:17 PM4/27/21
to open...@googlegroups.com
On 27.04.21 18:03, Even Rouault wrote:
> It seems to me the situation would be clearer (and that would save me some github pinging) if we just drop those components from the source tree (people might
> still reach them in older tags if needed)

I can see the big the benefit of the reduced maintenance effort when dropping these components. However my suggestion would be to try to keep them as much alive
as possible. If the components are just dropped, they are essentially dead. New people will have a pretty hard time identifying dropped components in the
history. And since the code is never compiled, it will pretty quickly become incompatible and/or difficult to resurrect.

Could you think of other options that bring the benefit of reduced maintenance effort but keep the code a bit more "alive"?

If nothing else, what about moving it to a dedicated repo like OpenJPEG-extras so that it can be "easily" pulled and build against upstream OpenJPEG? You could
declare the extras-repo as "community-maintained" and merge PRs only on best effort (or not at all, until someone steps up to review them).

Just my two cents!

Mario

Mickaël Savinaud

unread,
Apr 27, 2021, 2:49:50 PM4/27/21
to open...@googlegroups.com
Hi
+1
Mickaël 

You are subscribed to the mailing-list of the OpenJPEG project (www.openjpeg.org)

To post: email to open...@googlegroups.com
To unsubscribe: email to openjpeg+u...@googlegroups.com
For more options: visit http://groups.google.com/group/openjpeg

OpenJPEG is mainly supported by :
* UCL Image and Signal Processing Group (http://sites.uclouvain.be/ispgroup)
* IntoPIX (www.intopix.com)

---
You received this message because you are subscribed to the Google Groups "OpenJPEG" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openjpeg+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openjpeg/B3E65284-9CCC-4485-A3BF-3BF7DE1739C0%40uclouvain.be.

Even Rouault

unread,
Apr 27, 2021, 3:08:46 PM4/27/21
to open...@googlegroups.com, Mario Emmenlauer

Le 27/04/2021 à 20:49, Mario Emmenlauer a écrit :
> On 27.04.21 18:03, Even Rouault wrote:
>> It seems to me the situation would be clearer (and that would save me
>> some github pinging) if we just drop those components from the source
>> tree (people might still reach them in older tags if needed)
>
> I can see the big the benefit of the reduced maintenance effort when
> dropping these components. However my suggestion would be to try to
> keep them as much alive as possible. If the components are just
> dropped, they are essentially dead. New people will have a pretty hard
> time identifying dropped components in the history. And since the code
> is never compiled, it will pretty quickly become incompatible and/or
> difficult to resurrect.

It is already dead and doesn't compile, and worse than that, there are
no tests. Untested code is broken code. In the README.md, we might
indicate that the removed components existed up to v2.4.0 and people
that need them can just pick up from that tag if they need to resurrect
them.

Even Rouault

unread,
May 4, 2021, 1:51:29 PM5/4/21
to open...@googlegroups.com, Antonin Descampe
Hi,

Pull request removing JP3D, JPWL and MJ2 available in
https://github.com/uclouvain/openjpeg/pull/1350

Even
--
http://www.spatialys.com

Antonin Descampe

unread,
May 10, 2021, 9:11:42 AM5/10/21
to Even Rouault, open...@googlegroups.com
Thanks Even for preparing and merging this update.
The OpenJPEG value proposal is now much clearer.

Cheers,

Antonin

Le 4 mai 2021 à 19:51, Even Rouault <even.r...@spatialys.com> a écrit :



Even

Le 27/04/2021 à 20:33, Antonin Descampe a écrit :
Hi,

I support this proposal from Even: unless someone is willing to take care of the maintenance of these obsolete components, I would simply remove them from the source (while still available in the repo history).

Practically, and to give us a concrete timeline, if no answer is received by next Tuesday CoB (CEST), I suggest to proceed that way.

Cheers,

Antonin

Le 27 avr. 2021 à 18:03, Even Rouault <even.r...@spatialys.com> a écrit :

Hi,

it seems to me that besides openjp2, the openjpwl, openjp3d and openmj2 components are not in active use, and in particular they aren't built by the continuous integration, hence they are broken. I see people issuing pull requests to make them compile or fix security issues, but while probing a bit about their interest, it seems those people just compile them by habit (typically package maintainers) but not for personal use.

It seems to me the situation would be clearer (and that would save me some github pinging) if we just drop those components from the source tree (people might still reach them in older tags if needed)

I'm not sure what we should do with the openjpip component, which has a stronger connection with openjp2. I've no use of it personally. It is not built by the continuous integration either.

Thoughts ? (if someone doesn't agree with this proposal, then they'd have to step up to review pull requests related to those components and set up continuous integration for them ;-))

Even

-- 

My software is free, but my time generally not.

-- 

To post: email to open...@googlegroups.com
To unsubscribe: email to openjpeg+u...@googlegroups.com
For more options: visit https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgroups.google.com%2Fgroup%2Fopenjpeg&amp;data=04%7C01%7Cantonin.descampe%40uclouvain.be%7Cf980ec44755c481a615108d90f253d23%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637557475754980598%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=%2Bp4NFXHMCdPcUs46kPqhpxj0r8Vzb4ar3%2BbW9ByB7uo%3D&amp;reserved=0
OpenJPEG is mainly supported by : * UCL Image and Signal Processing Group (http://sites.uclouvain.be/ispgroup) * IntoPIX (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.intopix.com%2F&amp;data=04%7C01%7Cantonin.descampe%40uclouvain.be%7Cf980ec44755c481a615108d90f253d23%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637557475754980598%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=PWw%2Fsqp6Gy7jX5NoJbmgIzaEm6A43xw2WNlSi4NQtUo%3D&amp;reserved=0)

--- You received this message because you are subscribed to the Google Groups "OpenJPEG" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openjpeg+u...@googlegroups.com.
To view this discussion on the web visit https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fopenjpeg%2Fcfec5028-e90f-df52-ef83-45abd97aaccf%2540spatialys.com&amp;data=04%7C01%7Cantonin.descampe%40uclouvain.be%7Cf980ec44755c481a615108d90f253d23%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637557475754980598%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=NbfUeVwEdmjpVwTGjDAHF8AYNfG3gk7O%2B6TYeEFYAnk%3D&amp;reserved=0.

-- 
https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.spatialys.com%2F&amp;data=04%7C01%7Cantonin.descampe%40uclouvain.be%7Cf980ec44755c481a615108d90f253d23%7C7ab090d4fa2e4ecfbc7c4127b4d582ec%7C0%7C0%7C637557475754980598%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=B69ncFrWgtE04LLoFiOldtOJxcXPw7DVUhuRefx%2FYgA%3D&amp;reserved=0
Reply all
Reply to author
Forward
0 new messages