I think everyone should have a chance to try these out
Some comments for the agent:
- The welcome page should have a title and a description how to use web intents
- In the welcome page, the service registration should be first, then
the intents invocations
- The app crashes when calling the app management (having 5
applications pending) on a phone the first time, after starting the
sample app it worked.
- The menu "App management" should not contain "5 apps pending"
- Some visual feedback when a web app has been recognized (toast or
notification) would be good.
- Some animation when openining a new web page so people understand
how to come back to previous page
- Back button could be the same as the back arrow on the top (to be discuss)
- If no apps are available the dialog should behave in the same way as
the standard createChooser
- The app management should not show removed apps as new found or even
better visited apps
- In app management, when viewing an app there should be a plus/delete
button to add/remove it to/from my apps.
- In app management, the selection mode should be enabled already when
showing the activity, because the user came here to manage the apps,
maybe checkboxes are better
- Instead of delete icon there should be "-" or something similar
Some comments on the sample and library for Android apps:
- The dialog should be created in the same context/app, not in the web
agent activity, because the launched activity returns to the web agent
activity, not to the launching app
- The dialog shows web apps that I haven't registered, i.e. are still pending.
General:
- If you have copied the web page to the www assets please make a
short header indicating that this is a local copy of the
webintents.org page, using something like
https://github.com/neofoniemobile/Crouton
Cheers
Friedger
2012/8/7 Cheng Zheng :
> Attached are the two apk files. Please let me know if there is any problem.
>
> Thanks for all your comments. I will think about them carefully and get back
> to you asap
>
>
> On Mon, Aug 6, 2012 at 7:03 PM, Friedger Müffke wrote:
>>
>> Could you please send me both APKs as I am not able to compile the
>> code right now (due to my hardware).
>>
>> - I would like to see the WebIntents Agent App to have its own logo,
>> maybe just the OI logo, but that could be part of the documentation.
>> - the sample app should be in its own folder next to the agent app
>> - createChooserWithWebActivities should create a chooser dialog, not
>> launch the activity (which just shows a dialog)
>> - the class comments should be more useful, e.g. WebIntentsHelper:
>> Helper class to show web apps in the chooser dialog when starting an
>> activity through intents.
>> Developers of Android apps should use createChooserWithWebActivities
>> instead of createChooser
>> This class delegates the creation of the dialog to
>> WebIntentsHelperActivity.
>>
>> Comments that just repeats the name of the class is not necessary. I
>> know that OpenIntents has no guidelines on this.
>>
>> - The code structure could be improved. There is a lot of database
>> logic in the widget folder, widget should only contain visual stuff. I
>> had problems to find the code where the web apps HTML code is parsed.
>> - How do you handle text/* in the provider tables/queries?
>> - Some kind of magic mime-type matching would be nice as well for the
>> text/uri-list to text/plain for sharing
>>
>> Overall, I think you created a working app testing with single use
>> case "share". Do you think it will extend to PICK or EDIT? What would
>> be required to make it work.
>>
>>
>> BTW, in the first WebIntents hangout, they mentioned OpenIntents as
>> one possible provider of a web intents registry :-) So, we should
>> continue documenting our effort and complete the list of matching
>> actions in
http://www.openintents.org/en/intentsbigtable
>>
>> Cheers
>> Friedger
>>
>>