[openintents] r4260 committed - OI Safe: checks for empty website on Go button (patch by Kumar Sukhani...

[openi...@googlecode.com]

Revision: 4260
Author: rmc...@gmail.com
Date: Sat Apr 21 12:41:50 2012
Log: OI Safe: checks for empty website on Go button (patch by Kumar
Sukhani)

http://code.google.com/p/openintents/source/detail?r=4260

Modified:
/trunk/safe/Safe/readme.txt
/trunk/safe/Safe/res/values/strings.xml
/trunk/safe/Safe/src/org/openintents/safe/PassEdit.java
/trunk/safe/Safe/src/org/openintents/safe/PassView.java

=======================================
--- /trunk/safe/Safe/readme.txt Wed Apr 4 20:37:55 2012
+++ /trunk/safe/Safe/readme.txt Sat Apr 21 12:41:50 2012
@@ -31,6 +31,7 @@
- automatically open on-screen keyboard on "Master password" screen (issue
328, patch by Eldwin)
- clear master password if wrong (patch by Kumar Sukhani)
- empty password records not saved (patch by Eldwin)
+- checks for empty website on Go button (patch by Kumar Sukhani)

----------------
release: 1.3
=======================================
--- /trunk/safe/Safe/res/values/strings.xml Sun Apr 1 04:15:04 2012
+++ /trunk/safe/Safe/res/values/strings.xml Sat Apr 21 12:41:50 2012
@@ -254,7 +254,8 @@
<string name="nine">9</string>
<string name="numbersign">#</string>
<string name="asterisk">*</string>
-
+ <string name="invalid_url">Invalid URL</string>
+
<!-- ***************************
Permissions
*************************** -->
=======================================
--- /trunk/safe/Safe/src/org/openintents/safe/PassEdit.java Wed Apr 4
20:37:55 2012
+++ /trunk/safe/Safe/src/org/openintents/safe/PassEdit.java Sat Apr 21
12:41:50 2012
@@ -135,6 +135,12 @@

goButton.setOnClickListener(new View.OnClickListener() {
public void onClick(View arg0) {
+
+ String link = websiteText.getText().toString();
+ if (link == null || link.equals("") || link.equals("http://")) {
+ Toast.makeText(PassEdit.this, getString(R.string.invalid_url),
Toast.LENGTH_SHORT).show();
+ return;
+ }

Toast.makeText(PassEdit.this,
getString(R.string.password)+" "+getString(R.string.copied_to_clipboard),
Toast.LENGTH_SHORT).show();
@@ -143,7 +149,7 @@
cb.setText(passwordText.getText().toString());

Intent i = new Intent(Intent.ACTION_VIEW);
- String link = websiteText.getText().toString();
+
Uri u = Uri.parse(link);
i.setData(u);
try {
=======================================
--- /trunk/safe/Safe/src/org/openintents/safe/PassView.java Sun Feb 5
12:43:33 2012
+++ /trunk/safe/Safe/src/org/openintents/safe/PassView.java Sat Apr 21
12:41:50 2012
@@ -241,6 +241,7 @@

String link = websiteText.getText().toString();
if (link == null || link.equals("") || link.equals("http://")) {
+ Toast.makeText(PassView.this, getString(R.string.invalid_url),
Toast.LENGTH_SHORT).show();
return;
}