Issue 156 in openid4java: replace commons logging with slf4j?

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 156 by hielke.hoeve: replace commons logging with slf4j?
http://code.google.com/p/openid4java/issues/detail?id=156

It is much better to use slf4j than commons logging. It is possible for
everyone to stick to their chosen implementation. As most frameworks use
slf4j it is quite a hassle to work around commons logging using a dummy
implementation.

Also note this article: http://articles.qos.ch/thinkAgain.html and the
references at the bottom.

[codesite...@google.com]

Comment #1 on issue 156 by joe.walt...@gmail.com: replace commons logging
with slf4j?
https://code.google.com/p/openid4java/issues/detail?id=156

Agreed. Having libraries use slf4j as their facade simplifies integration,
and the existence of slf4j-jcl means projects that want to stick with
commons-logging just need to include that to bridge across.

The APIs are similar enough that the change is simply a matter of changing
the logger definitions and importing the dependencies; patch attached.

On top of this, it may be worth using slf4j's parameterised logging to
remove the 'if (DEBUG)' checks.

Attachments:
openid4java-156-use-slf4j-api.patch 65.8 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings