Issue 146 in openid4java: Warnings cleanup
codesite...@google.com
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 146 by adi...@gmail.com: Warnings cleanup
http://code.google.com/p/openid4java/issues/detail?id=146
Hi, here is a patch to get rid of over 500 warnings in openid4java. It is
applicable to SVN revision 659.
Most of the changes involve generic collections, foreach, annotations and
varargs.
The code is compatible with java 6; if you need java 5 compatibility then I
can modify it (but the differences should be trivial).
I excluded a bunch of classes that I don't use; I haven't touched those.
I haven't fixed any serializable class without serialVersionUID.
I also haven't removed unnecessary declarations of thrown exceptions,
except in SampleConsumer.
To the best of my knowledge, the changes don't affect the functionality in
any way. It might cause some compile errors in the classes I excluded (due
to the use of generics), but they should be trivial to fix.
Attachments:
patch.txt 123 KB
codesite...@google.com
Comment #1 on issue 146 by sj1...@gmail.com: Warnings cleanup
http://code.google.com/p/openid4java/issues/detail?id=146
I wonder why a library that has been started by end of 2006 does not at
least use generics, which were introduced with Java 5 in 2004? :-( That's a
dealbreaker for me.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings