Initial contribution Vitotronic binding - need help

37 views
Skip to first unread message

Stefan Andres

unread,
Mar 26, 2015, 1:32:11 PM3/26/15
to open...@googlegroups.com
My developing of the "Initial contribution Vitotronic binding" is finished.
The bindig is (developer) tested  with real hardware and from my few it runs stable.

I new in openhab/openhab2 and I don't know the development process for bindings.
The binding itself is published on my fork: https://github.com/steand/openhab2/tree/vitotronic/addons/binding/org.openhab.binding.vitotronic


What are the next steps that the binding goes into the upstream?

Also I will be happy, if someone can review my code and think definitions.

Thanks
Regards Stefan


Kai Kreuzer

unread,
Mar 26, 2015, 3:36:17 PM3/26/15
to open...@googlegroups.com
Hi Stefan,

Thanks! The last step is to create a Pull Request from your branch - you should find an according button on Github when looking at your branch.
Please also see https://github.com/openhab/openhab2/blob/master/CONTRIBUTING.md#conventions - it is important that you sign off your commit (or at least the PR).

Best regards,
Kai


--
You received this message because you are subscribed to the Google Groups "openhab2" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openhab2+u...@googlegroups.com.
To post to this group, send email to open...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openhab2/4c637102-b6c3-41f3-80e9-2ba486dc4ea4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply all
Reply to author
Forward
0 new messages