[caciviclab/disclosure-backend-static] Filter all queries to the highest Report_Num value (#22)
Tom Dooner
This [Fixes #21] by using a postgres-specific "DISTINCT ON" clause to
return only the first distinct row for a set of columns matching the
previous GROUP BY column set. The new GROUP BY includes "Report_Num"
column. To ensure deterministic behavior, we also must add an ORDER BY
clause like:
ORDER BY [...distinct on columns...], "Report_Num" DESC
See http://stackoverflow.com/a/13327987/910723 for more details.
I manually audited the two affected organizations -- Just Cause and the
Committee to Protect Oakland Renters -- to verify that the new totals
match the most recent report figures only.
You can view, comment on, or merge this pull request online at:
https://github.com/caciviclab/disclosure-backend-static/pull/22
Commit Summary
- Filter all queries to the highest Report_Num value
File Changes
- M build/referendum/3/supporting/index.json (2)
- M build/referendum/4/supporting/index.json (2)
- M calculators/candidate_contributions_by_type.rb (17)
- M calculators/candidate_expenditures_by_type.rb (6)
- M calculators/referendum_supporters_calculator.rb (12)
- M calculators/total_contributions_calculator.rb (12)
- M calculators/total_expenditures_calculator.rb (12)
- M calculators/total_loans_received_calculator.rb (12)
Patch Links:
- https://github.com/caciviclab/disclosure-backend-static/pull/22.patch
- https://github.com/caciviclab/disclosure-backend-static/pull/22.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.