[caciviclab/disclosure-backend-static] Committee endpoint (#16)
Aaron D Borden
Adds a committee endpoint in order to get information about a specific committee.
You can view, comment on, or merge this pull request online at:
https://github.com/caciviclab/disclosure-backend-static/pull/16
Commit Summary
- Import oakland committees from google sheet
- Link committees from schedule E
File Changes
- M Makefile (5)
- M README.md (6)
- M calculators/candidate_contributions_by_type.rb (2)
- M calculators/candidate_expenditures_by_type.rb (2)
- M calculators/referendum_supporters_calculator.rb (28)
- M calculators/total_contributions_calculator.rb (2)
- M calculators/total_expenditures_calculator.rb (2)
- M calculators/total_loans_received_calculator.rb (2)
- A models/oakland_committee.rb (31)
- M process.rb (7)
Patch Links:
- https://github.com/caciviclab/disclosure-backend-static/pull/16.patch
- https://github.com/caciviclab/disclosure-backend-static/pull/16.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Tom Dooner
@tdooner approved this pull request.
Cool, looks good other than that one weird thing which might actually work because of Ruby :magic:
In calculators/referendum_supporters_calculator.rb:
> @ballot_measures = ballot_measures
+ @committees_by_filer_id = committees
+ committees.where('"Filer_ID" IS NOT NULL').index_by { |c| c.Filer_ID }
This looks wrong to me, I don't think the WHERE will be applied to the original query.
You should remove the committees on line 5
Aaron D Borden
@adborden commented on this pull request.
In calculators/referendum_supporters_calculator.rb:
> @ballot_measures = ballot_measures
+ @committees_by_filer_id = committees
+ committees.where('"Filer_ID" IS NOT NULL').index_by { |c| c.Filer_ID }
Oh yeah, thanks. Totally a typo.
Aaron D Borden
@adborden pushed 1 commit.
- 97ec018 Fix typo
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Aaron D Borden
So fixing that caused other problems, so it obviously wasn't working. Do I have this right? The committee files schedule E for their expenditures, that actually makes them the "payer" not the "payee", right?
Aaron D Borden
@adborden pushed 1 commit.
- 7c205ea Use keys as strings
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Aaron D Borden
Decided to dig into why we still had no IDs for some of the Oakland committees so turned up another fix. Looks like we were able to match a committee to all of the referendum expenditures in oakland 🏆
$ grep -r "id.*null" build/referendum/ | wc -l
0
Tom Dooner
Merged #16.
Tom Dooner
Ah yeah, this looks right. Filer_ID should always be a string. Thanks for digging in to find the bug. Next time, you should run make process and include the changes in build to the PR (in a separate commit from the rest of your code changes). 👍