[Openbravo-builds] int-addpayment2-pgsql - Build # 427 - Failure!

[jen...@ci.openbravo.com]

int-addpayment2-pgsql - Build # 427 - Failure:

Check console output at https://ci.openbravo.com/job/int-addpayment2-pgsql/427/ to view the results.


Committers since last success:

Changes for Build #427

Asier Lostalé <asier....@openbravo.com> null
fixes 40750: raised minimum supported Oracle database version from 11.1 to 11.2
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseVersionCheck.class
src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseVersionCheck.java
src-util/diagnostic/config/diagnostics.properties

Nono Carballo <non...@gmail.com> null
Fixes issue 40559: Uses bind parameters in query

Instead of using string concatenation in client and organization filters in
where clause, bind parameters are used
src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40579: Uses bind parameters in query

Instead of using string concatenation in query, bind parameters are used.
src/org/openbravo/financial/ResetAccounting.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40698: Filters accounting reports by organization.

Prior this fix, when selecting accounting reports, organizations the role has
access were not considered.
This fix retrieves accounting reports considering organizations the current
role has access.
src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports_data.xsql




Last 20 lines of the console output:

[...truncated 4651 lines...]
+ (( i=0 ))
+ (( i<12 ))
++ jps
++ grep Bootstrap
++ true
+ '[' '' = '' ']'
+ break
++ jps
++ grep Bootstrap
++ true
+ '[' '' '!=' '' ']'
+ true
+ '[' 0 '!=' 0 ']'
+ echo

POST BUILD TASK : SUCCESS
END OF POST BUILD TASK : 0
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any

[jen...@ci.openbravo.com]

int-addpayment2-pgsql - Build # 428 - Fixed:

Check console output at https://ci.openbravo.com/job/int-addpayment2-pgsql/428/ to view the results.

Committers since last success:

Changes for Build #427

Asier Lostalé <asier....@openbravo.com> null
fixes 40750: raised minimum supported Oracle database version from 11.1 to 11.2
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseVersionCheck.class
src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseVersionCheck.java
src-util/diagnostic/config/diagnostics.properties

Nono Carballo <non...@gmail.com> null
Fixes issue 40559: Uses bind parameters in query

Instead of using string concatenation in client and organization filters in
where clause, bind parameters are used
src/org/openbravo/erpCommon/ad_callouts/SL_TaxCategory_Org.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40579: Uses bind parameters in query

Instead of using string concatenation in query, bind parameters are used.
src/org/openbravo/financial/ResetAccounting.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40698: Filters accounting reports by organization.

Prior this fix, when selecting accounting reports, organizations the role has
access were not considered.
This fix retrieves accounting reports considering organizations the current
role has access.
src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports_data.xsql

Changes for Build #428

RM packaging bot <staf...@openbravo.com> null
Merge back from main

RM packaging bot <staf...@openbravo.com> null
Merge temporary head for 3.0PR19Q1.1

RM packaging bot <staf...@openbravo.com> null
Added signature for changeset 10080fe6bda1
.hgsigs

RM packaging bot <staf...@openbravo.com> null
Added tag 3.0PR19Q1.1 for changeset 5a9355cfa0e6
.hgtags

RM packaging bot <staf...@openbravo.com> null
Update AD_MODULE version to 3.0PR19Q1.1
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_MODULE.xml

Augusto Mauch <august...@openbravo.com> null
Fixes issue 40782: Standard properties are taken from underlying window in P&E

When a P&E window contains a grid and a request to the datasource of the P&E window is done, it is
not clear whether the P&E grid or the underlying grid standard properties (tabId, tableId, windowId, etc)
should be included in the contextInfo.

Before this changeset [1] was pushed, the standard properties were taken from the underlying grid. The
changeset modified the behaviour, so that the P&E grid standard properties were included instead.
This was necessary because the SelectorConstants.includeOrgFilter method needed the table ID of the
P&E grid.

But the change caused another problem: Some OBBindings were relying on the underlying grid standard
properties being included in the contextInfo.

To fix both problems, now a new property called inpPickAndExecuteTableId is included when doing a
request from a P&E grid, and that property is referenced by SelectorConstants.includeOrgFilter.

The contextInfo now will include the standard properties of the underlying grid, as it was done
before [1].

[1] https://code.openbravo.com/erp/devel/pi/rev/1ed089db27e7036cf53026ca873dbcf104d79bb9
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorConstants.java

Jorge Garcia <jorge....@openbravo.com> null
Fixed issue 40791: Roles require back-office access to log in to mobile apps

MobileLoginHandler does a back-office login to later select mobile default role,
it expects back-office to fail and keep session in case of restricted role login
attempt.

Back-office login handler was changed to fail and remove session in case there is
no back-office role in current user's list. This made not possible to log in to
mobile apps.

Now if logging in to a mobile application session is kept after failure as it was
before.
src/org/openbravo/base/secureApp/LoginHandler.java

Carlos Aristu <carlos...@openbravo.com> null
fixes issue 40743: wrong export to CSV having the grid filtered by a date time

After the following changeset[1], exporting the grid to CSV was not working properly having the grid filtered by a date time column. Although the fix is correct, it caused the criteria sent to the datasource in this type of requests to stop being handled properly.

To avoid this problem, when exporting to CSV a grid filtered by a date time column we send in the criteria the plain date (in the same way as it is being done for the standard grid DS requests) and the datasource will take care of building the date filter properly through the AdvancedQueryBuilder.

[1] https://code.openbravo.com/erp/devel/pi/rev/90ee5c965823996a7b4c0ae17d3a3ca71e3fc703
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js

Víctor Martínez Romanos <victor....@openbravo.com> null
Related to issue 40700: code review improvements
Centralize localStrLine definition in just one line, when it's used.
Change parameter names to make more difficult to have conflicts with user defined params.
Remove 'if' for corner case. This creates a very small change in this scenario:
select 'RecordId: ' || @RecordId@ || ', Line: ' || @Line@ from dual
When Line is null then:
Before: NULL
After: RecordId: 3232199ED4824EE3A07BCC1E580ABFE7, Line: NULL
src/org/openbravo/erpCommon/ad_forms/FactLine.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40700: Uses bind parameters in query

Instead of using string concatenation to form the query, bind parameters are
used.
src/org/openbravo/erpCommon/ad_forms/FactLine.java

Carlos Aristu <carlos...@openbravo.com> null
fixes bug 40644: centralize in XMLUtils creation of objects to deal with XML
src-test/src/org/openbravo/test/dal/IssuesTest.java
src-test/src/org/openbravo/test/webservice/BaseWSTest.java
src/org/openbravo/base/provider/OBProviderConfigReader.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/base/session/OBPropertiesProvider.java
src/org/openbravo/dal/xml/EntityExcelXMLConverter.java
src/org/openbravo/dal/xml/EntityXMLConverter.java
src/org/openbravo/dal/xml/XMLUtil.java
src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
src/org/openbravo/erpCommon/modules/ImportModule.java
src/org/openbravo/erpCommon/utility/ISOCurrencyPrecision.java
src/org/openbravo/service/rest/DalWebService.java
src/org/openbravo/service/web/WebServiceUtil.java

Asier Lostalé <asier....@openbravo.com> null
fixed issue 40713: HelpWindow.generateWindow is not using bind-variables
src/org/openbravo/erpCommon/ad_help/HelpWindow.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40703: Escapes values printed to servlet response

Escapes values before printing them to Servlet response.
src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java

Sandra Huguet <sandra...@openbravo.com> null
related to issue 40682 code review changes
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40682: Prevents use of string concatenation in query

Query to get business partners was formed using string concatenation.
This fix replaces the string concatenation by bind parameters in query.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java

Sandra Huguet <sandra...@openbravo.com> null
Fixed issue 40672 Fix query to compare organization with corresponding id.

Fix query to compare organization with corresponding id instead of the
business object.

Fix wrong filter date, period.getEndingDate() is used and the correct
one is period.getStartingDate().
src/org/openbravo/materialmgmt/ResetValuedStockAggregated.java

Nono Carballo <non...@gmail.com> null
Fixes issue 40639 fix match business partner by token

Fix match business partner by token in import bank statement process
Do properly the get in businessPartnersScroll
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java

Asier Lostalé <asier....@openbravo.com> null
fixed bug 40655: Discounts and Promotions window fails under some circumstances

When Discount and Promotions view was requested having previously initialized
ADCS with that window via FIC a LazyInitializationException was thrown.

The problem is this window has a tree reference field which was partially initialized
in ADCS.
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

Javier Armendáriz <javier.a...@openbravo.com> null
Fixed issue 40605: NPE if email timeout is not set

Adding another null check to verify not only in the case that the email config
does not exist, but also that the timeout value is empty. In both cases the
default timeout should be used.
src/org/openbravo/erpCommon/utility/poc/EmailManager.java

Asier Lostalé <asier....@openbravo.com> null
fixed bug 40406: logs from callouts don't include callout class name
src-core/src/org/openbravo/base/HttpBaseServlet.java
src/org/openbravo/erpCommon/ad_callouts/DelegateConnectionProvider.java

Last 20 lines of the console output:

[...truncated 10852 lines...]
[ "$(jps | grep Bootstrap || true)" = "" ] && break
sleep 5
done
[ "$(jps | grep Bootstrap || true)" != "" ] && echo "Tomcat has fail to stop" && exit 1 || true
[ "$i" != "0" ] && secs=$(echo "$i * 5" | bc) && echo "Waiting for $secs secs for tomcat to stop"

echo
fi

[int-addpayment2-pgsql] $ /bin/bash -xe /tmp/hudson4256431187949090068.sh

++ jps
++ grep Bootstrap
++ true
+ '[' '' '!=' '' ']'

POST BUILD TASK : SUCCESS
END OF POST BUILD TASK : 0

Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed