Re: use unique_ptr instead of auto_ptr in c++11 mode (issue 78010043)

1 view
Skip to first unread message

mos...@opera.com

unread,
Apr 8, 2014, 4:58:14 PM4/8/14
to tha...@chromium.org, joc...@chromium.org, openv...@gmail.com, open-...@googlegroups.com, re...@codereview-hr.appspotmail.com

https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h
File src/unique_ptr.h (right):

https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h#newcode1
src/unique_ptr.h:1: #ifndef UNIQUE_PTR_H
On 2014/04/08 18:58:18, Lincoln wrote:
> This needs to start with a comment containing the Apache license block
and
> describing the purpose of this file.

Done.

https://codereview.appspot.com/78010043/diff/1/src/unique_ptr.h#newcode3
src/unique_ptr.h:3:
On 2014/04/08 18:55:17, Lincoln wrote:
> Shouldn't this file include <memory> so that the implementation of
unique_ptr or
> auto_ptr is available to modules that include this? If it's present
here, then
> "#include <memory>" can be removed from each of those modules.

Done.

https://codereview.appspot.com/78010043/diff/1/src/vcdecoder.cc
File src/vcdecoder.cc (right):

https://codereview.appspot.com/78010043/diff/1/src/vcdecoder.cc#newcode46
src/vcdecoder.cc:46: #include "unique_ptr.h"
On 2014/04/08 18:55:17, Lincoln wrote:
> Please add in alphabetical order.

Done.

https://codereview.appspot.com/78010043/
Reply all
Reply to author
Forward
0 new messages