Re: Issue 33 in open-vcdiff: open-vcdiff shouldn't log using cerr

13 views
Skip to first unread message

open-...@googlecode.com

unread,
Dec 8, 2011, 11:02:25 PM12/8/11
to open-...@googlegroups.com
Issue 33: open-vcdiff shouldn't log using cerr
http://code.google.com/p/open-vcdiff/issues/detail?id=33

This issue is now blocking issue chromium:94794.
See http://code.google.com/p/chromium/issues/detail?id=94794

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

open-...@googlecode.com

unread,
Dec 8, 2011, 10:58:23 PM12/8/11
to open-...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 33 by tha...@google.com: open-vcdiff shouldn't log using cerr
http://code.google.com/p/open-vcdiff/issues/detail?id=33

#include <iostream> introduces static initializers, see
http://crbug.com/94794

open-vcdiff logs through cerr. If open-vcdiff must log, it should use
fprintf(stderr, ...) – or, probably better, provide a log handler that
embedders could override to do what they please.

open-...@googlecode.com

unread,
Dec 9, 2011, 3:33:01 PM12/9/11
to open-...@googlegroups.com

Comment #3 on issue 33 by tha...@chromium.org: open-vcdiff shouldn't log
using cerr
http://code.google.com/p/open-vcdiff/issues/detail?id=33

This causes 12% of all files with static initializers in chrome/mac (not
counting protobuf initializers). The good news is that all of them are just
caused by the use of iostream.

Here's a list of the files with static initializers:
addrcache.o
codetable.o
decodetable.o
unicodetext.o
varint_bigendian.o
vcdecoder.o


open-...@googlecode.com

unread,
Dec 9, 2011, 3:37:03 PM12/9/11
to open-...@googlegroups.com
Issue 33: open-vcdiff shouldn't log using cerr
http://code.google.com/p/open-vcdiff/issues/detail?id=33

This issue is now blocking issue chromium:94925.
See http://code.google.com/p/chromium/issues/detail?id=94925

open-...@googlecode.com

unread,
Nov 13, 2013, 12:19:00 AM11/13/13
to open-...@googlegroups.com

Comment #11 on issue 33 by tha...@chromium.org: open-vcdiff shouldn't log
using cerr
http://code.google.com/p/open-vcdiff/issues/detail?id=33

We managed to work around this in chromium without changes in open-vcdiff (
https://codereview.chromium.org/68253006 ).

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages