Issue 34 in open-vcdiff: Allow linking zlib library

[open-...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 34 by wangxian...@chromium.org: Allow linking zlib library
http://code.google.com/p/open-vcdiff/issues/detail?id=34

open-vcdiff contains old copies of zlib's adler32.c, zlib.h and zconf.h.
For a project that uses open-vcdiff and links to zlib library (e.g.
Chromium), the duplicated code will cause unnecessary binary size increase,
or conflicts during linking.

[open-...@googlecode.com]

Comment #2 on issue 34 by wangxian...@chromium.org: Allow linking zlib
library
http://code.google.com/p/open-vcdiff/issues/detail?id=34

Proposed patch using the method in #1.

Attachments:
patch 86.8 KB

[open-...@googlecode.com]

Comment #3 on issue 34 by wangxian...@chromium.org: Allow linking zlib
library
http://code.google.com/p/open-vcdiff/issues/detail?id=34

Actually I moved zlib, zconf.h and adler32.c into src/zlib, but my patch
generated with 'svn diff' seems not to replay that.

FYI, the output of 'svn status':
M Makefile.in
A src/zlib
A + src/zlib/zconf.h
A + src/zlib/zlib.h
A + src/zlib/adler32.c
D src/zconf.h
D src/zlib.h
D src/adler32.c
M vsprojects/vcdcom/vcdcom.vcproj
M Makefile.am

[open-...@googlecode.com]

Updates:
Status: Fixed

Comment #4 on issue 34 by openvcd...@gmail.com: Allow linking zlib library
http://code.google.com/p/open-vcdiff/issues/detail?id=34

Patch included in version 0.8.3 of open-vcdiff. Thanks much for reporting
the issue and for providing a patch.