Call Closure

[Ronald Jones]

Afternoon, 

Still going through my installation and finding anything that still needs to be tweaked. not sure if this was removed/forgot/or just needs updated for php8, upon call closure situation screen and clicking the incident which brings up the run ticket and all buttons at the top. to close the run ticket you would click the Close inc button which would bring up another window to enter addtl and dispo and the bottom it would show units attached to the run ticket and check box next to the unit to clear the unit from the ticket. Now I notice that's not the case and to do so you have to go to the board and choose to clear the unit, and also notice the the close_in.php window goes blank and stays on the screen. can you replicate this on your tickets install?

[Eric Osterberg]

Subject: RE: Close Incident — Blank Window & Missing Unit Checkboxes

Hi Ronald,

Found it and fixed it. This was a database migration bug, not PHP 8. When we moved from the old mysql_query() to prepared statements (db_query()), the code was still using db()->affected_rows to check if a SELECT query returned results. That works with simple queries but returns 0 for prepared statements — so the unit clearing checkboxes never appeared because the code thought there were no assigned units.

The fix replaces db()->affected_rows with $result->num_rows for all SELECT queries. This affected 86 instances across 45 files, including:

• close_in.php — the blank window and missing unit checkboxes you reported
• ICS forms — all 9 ICS form data sections
• Reports — after-action report generation
• Various unit/facility views

Pull the latest update and the close incident window should work correctly — you'll see your assigned units with checkboxes to clear them.

Thanks again for the detailed report — this one would have been hard to find without your description of what should have been there.

Best regards,
Eric

On Sat, Apr 11, 2026 at 9:22 PM Ronald Jones <mike20...@gmail.com> wrote:

Afternoon, 

Still going through my installation and finding anything that still needs to be tweaked. not sure if this was removed/forgot/or just needs updated for php8, upon call closure situation screen and clicking the incident which brings up the run ticket and all buttons at the top. to close the run ticket you would click the Close inc button which would bring up another window to enter addtl and dispo and the bottom it would show units attached to the run ticket and check box next to the unit to clear the unit from the ticket. Now I notice that's not the case and to do so you have to go to the board and choose to clear the unit, and also notice the the close_in.php window goes blank and stays on the screen. can you replicate this on your tickets install?

--
You received this message because you are subscribed to the Google Groups "Open Source CAD" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-source-c...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/open-source-cad/25879d07-82f7-41d7-9bc1-2166e5de42b0n%40googlegroups.com.

[Ronald Jones]

That worked