reverse geocoding

[Ronald Jones]

the reverse geocoding feature doesn't seem to work as when i click on the map it shows blank bubble and it clears out the city and state in the call entry screen but will enter the lat and long. I've tried using Bing as the geocoding provider but all it shows on the map in the bubble that popups  is [object object] OH.

Open street map, does it use the reverse geo coding ?

[Eric Osterberg]

There was a fix about 6 months ago that resolved the API providers changes to the URL for Geocoding. They basically required a trailing '/' to be removed.

If you can apply the latest version, the issue will be resolved.

I'm not aware of Bing being supported or enabled with TicketsCAD. Maybe you can share more information about that?

You can always grab the very latest beta or work in progress at: https://github.com/openises/tickets/archive/refs/heads/main.zip

Or find releases at: https://github.com/openises/tickets/releases

On Wed, Feb 7, 2024 at 7:40 PM Ronald Jones <mike20...@gmail.com> wrote:

the reverse geocoding feature doesn't seem to work as when i click on the map it shows blank bubble and it clears out the city and state in the call entry screen but will enter the lat and long. I've tried using Bing as the geocoding provider but all it shows on the map in the bubble that popups  is [object object] OH.

Open street map, does it use the reverse geo coding ?

--
You received this message because you are subscribed to the Google Groups "Open Source CAD" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-source-c...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/42e129e6-4b0d-421c-a730-c898bba08dc4n%40googlegroups.com.

[Ronald Jones]

i have the latest tickets version

[Eric Osterberg]

I am sorry I don't have any quick answers for you. I have not explored the other geocoding providers. I was aware of the faults in the default geocoder 6 months ago and provided a patch once the issue was discovered.

Maybe others have ideas or you can provide screenshots that demo the problem?

I was just reviewing the installation I have before me... And while it shows the version to be v3.40.3, I know that it does not have the fixes that are in the newest code.

For troubleshooting, What I did was:

1) open the screen where I expected GeoCoding to work.

2) open the debugger in my web browser... (I'm using firefox, Click Tools, Browser Tools, Web developer tools)

3) click the "network tab" in the developer plane.

4) Once I had this visible, I clicked on the map and watched the developer tools area where I saw a 404 error message.

5) I clicked into the details of the 404 error and found the URL the javascript was trying to load.

It was: https://nominatim.openstreetmap.org/reverse/?lat=33.454359789517014&lon=-112.14747626334429&zoom=-4&addressdetails=1&format=json&json_callback=_l_geocoder_2

6) when I loaded that into a new browser tab... I saw the error from the API provider telling me the URL had changed.

7) this told me the URL changed and I needed to remove the trailing slash...

  And I know this change(fix) is in the latest version.

   So for me to verify this is working... I'll need to update to the latest version of the code.  My own system here in Arizona where I am for the next week, needs to be updated.

So to hunt this down for you...

Looks like the file that changed was js/Control.Geocoder.js

This was corrected on August 6th. https://github.com/openises/tickets/commit/eca28668008eb4644e3d7abb09e76af1b39937ec

And you need the latest, rather than the newest "release".  So please use the version at: https://github.com/openises/tickets/archive/refs/heads/main.zip

Or explore the links above and apply the patch to js/Control.Geocoder.js

Hopefully this fixes the issue for you.

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/a8ab7126-a95e-495a-98db-e98d8a5ec61bn%40googlegroups.com.

[Ronald Jones]

default city and state disappear when clicking on the map for geocoding. the only fields that updates is the lat/long USNG. i looked at the reference you field in fire fox and in chrome both say that geocoding is good just dont know why the map returns blank information

. 

[Eric Osterberg]

When you capture the connection to the Geocoder, can you cut and paste that URL into a new browser window and inspect the results?

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/cbdcc655-e286-4e4b-8e78-a7049e31bd60n%40googlegroups.com.

[Eric Osterberg]

In my case, this is what was returned.

_l_geocoder_2({"place_id":77249893,"licence":"Data © OpenStreetMap contributors, ODbL 1.0. http://osm.org/copyright","osm_type":"relation","osm_id":148838,"lat":"39.7837304","lon":"-100.445882","class":"boundary","type":"administrative","place_rank":4,"importance":0.9356913674575887,"addresstype":"country","name":"United States","display_name":"United States","address":{"country":"United States","country_code":"us"},"boundingbox":["-14.7608358","71.5889534","-180.0000000","180.0000000"]})

Not sure if anyone else can verify this is working for them?

I'll be happy to update the project when a solution is available.

[mike]

https://nominatim.openstreetmap.org/reverse?lat=41.500017916334116&lon=-81.68544920801651&zoom=-4&addressdetails=1&format=json&json_callback=_l_geocoder_0

this is what was returned when copy/past into a new browser tab

_l_geocoder_0({"place_id":77249893,"licence":"Data © OpenStreetMap contributors, ODbL 1.0. http://osm.org/copyright","osm_type":"relation","osm_id":148838,"lat":"39.7837304","lon":"-100.445882","class":"boundary","type":"administrative","place_rank":4,"importance":0.9356913674575887,"addresstype":"country","name":"United States","display_name":"United States","address":{"country":"United States","country_code":"us"},"boundingbox":["-14.7608358","71.5889534","-180.0000000","180.0000000"]})

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/CAJLaYFV-mkDuz18ODnW6CK5v7xXYbOz%3D7UzhCcJjVOM0G%2Bg8rA%40mail.gmail.com.

[jms.comp...@gmail.com]

https://nominatim.org/release-docs/latest/api/Reverse/

ZoomLevel - Level of detail required for the address. This is a number that corresponds roughly to the zoom level used in XYZ tile sources in frameworks like Leaflet.js, Openlayers etc. In terms of address details the zoom levels are as follows:

Try setting your Zoon from -4 to either 

   17 - Major and MMinor Street    

    or 

   18 - Building 

https://nominatim.openstreetmap.org/reverse?lat=40.7127281&lon=-74.0060152&zoom=18&format=json&addressdetails=1

{"place_id":13489971,"licence":"Data © OpenStreetMap contributors, ODbL 1.0. http://osm.org/copyright","osm_type":"way","osm_id":575213527,"lat":"40.71273945","lon":"-74.00593904130275","class":"amenity","type":"townhall","place_rank":30,"importance":0.4208031717481289,"addresstype":"amenity","name":"New York City Hall","display_name":"New York City Hall, 260, Broadway, Lower Manhattan, Manhattan Community Board 1, Manhattan, New York County, New York, 10000, United States","address":{"amenity":"New York City Hall","house_number":"260","road":"Broadway","quarter":"Lower Manhattan","neighbourhood":"Manhattan Community Board 1","suburb":"Manhattan","county":"New York County","city":"New York","state":"New York","ISO3166-2-lvl4":"US-NY","postcode":"10000","country":"United States","country_code":"us"},"boundingbox":["40.7124450","40.7130254","-74.0064455","-74.0055687"]}

[Ronald Jones]

I tried the zoom level suggestion but still the same result with blank Bubble icon and city and state being removed from the fields for new call entry. not sure if this would have anything to do with the geocoding or not.

[jms.comp...@gmail.com]

Robert,  

   As I read the two Deprecation Warnings they do not apply here.  This is not a single object by OSM id lookup and the URL being referenced is reverse not the older reverse.php.

   As I posted using the Lat & Lon you provided above and Zoom level of 18 (note you had -4) the API returned the data expected.  

   ---

[mike]

I was able to get the zoom to change to 18 and it’s still the same result

Sent from my iPhone

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/ef66d4f5-d611-4467-8516-cbff8495b06an%40googlegroups.com.

[Eric Osterberg]

The version v3.42.0 was officially released 10 minutes ago.

This is exactly the same as the "HEAD" or https://github.com/openises/tickets/archive/refs/heads/main.zip version, with the version number being updated to remove any doubt about what version a person is running.

You can also find this on SourceForge at: https://sourceforge.net/projects/openises/files/   I am going to recommend you grab the versions from GITHUB as that's where we're maintaining the software now.

If you only want to run "Releases", you'll find those at: https://github.com/openises/tickets/releases

Numerous fixes are in this "Release".  You can follow changes to the code, line by line, with a description of why at: https://github.com/openises/tickets/commits/main/

Learning GIT is an awesome thing to do.

When you learn to manage an installation with it, updating your system can be as simple as running this command in the shell: "git pull".

Then you're all done.  Simple as that, and you have the very latest version.

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/CADuRW1yKJs-do3t9u-1ZHqYx06T2pZfWCvQcRsvpFv_wvyiOow%40mail.gmail.com.

[jms.comp...@gmail.com]

So I am not as familiar with this code as many here -- 

But as noted above -- control.geocoder.js 

Line 310 -- Function that builds the Query Executes it and Returns the results -- 

The 

Line 367 - Seems to build the URL setting fro the Query at 310 -- But Line 371 is doing some interesting math instead of just setting a Zoom Level?  

Also,  

In the resulting URL that I tested in a Browser is the json_callback and I am not sure where this parm or value comes froms. 

https://nominatim.openstreetmap.org/reverse?lat=41.500017916334116&lon=-81.68544920801651&zoom=18&addressdetails=1&format=json&json_callback=_l_geocoder_0

But at least in my browser I get exactly what I would have expected and the only change here is from -4 to 18,. 

_l_geocoder_0({"place_id":24674837,"licence":"Data © OpenStreetMap contributors, ODbL 1.0. http://osm.org/copyright","osm_type":"way","osm_id":366882348,"lat":"41.500068549999995","lon":"-81.68539577310509","class":"building","type":"apartments","place_rank":30,"importance":9.99999999995449e-06,"addresstype":"building","name":"The Ivory on Euclid","display_name":"The Ivory on Euclid, 1020, Euclid Avenue, Downtown Cleveland, Cleveland, Cuyahoga County, Ohio, 44114, United States","address":{"building":"The Ivory on Euclid","house_number":"1020","road":"Euclid Avenue","neighbourhood":"Downtown Cleveland","city":"Cleveland","county":"Cuyahoga County","state":"Ohio","ISO3166-2-lvl4":"US-OH","postcode":"44114","country":"United States","country_code":"us"},"boundingbox":["41.4998328","41.5003039","-81.6856307","-81.6850928"]})

Hope this helps some -- But if not just disregard it.

[mike]

It seems to capture the relevant information but does not input location into the call entry ( city, state, address, and a blank icon bubble. This use to work in early version of tickets 2.x. Not sure if the code is missing something or not. I’ve updated to the version that was released yesterday 3.42.0. And still same. 

Sent from my iPhone

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/3495c753-b0ff-4e1a-b400-ac4cad63c04fn%40googlegroups.com.

[jms.comp...@gmail.com]

In the module add.php --   Last change seemed to be 2013..  But, 

At Line 2312 looks like it would ignore your clicking on a map if a variable (switch) is not set.   

var theLocale = <?php print get_variable('locale');?>;
var useOSMAP = <?php print get_variable('use_osmap');?>;
var initZoom = <?php print get_variable('def_zoom');?>;
init_map(2, <?php print get_variable('def_lat');?>, <?php print get_variable('def_lng');?>, "", parseInt(initZoom), theLocale, useOSMAP, "tr");
var bounds = map.getBounds();
var zoom = map.getZoom();
var got_points = false; // map is empty of points
var doReverse = <?php print intval(get_variable('reverse_geo'));?>;
function onMapClick(e) {
if(doReverse == 0) {return;}
if(marker) {map.removeLayer(marker);}
if(myMarker) {map.removeLayer(myMarker);}
var iconurl = "./our_icons/yellow.png";
icon = new baseIcon({iconUrl: iconurl});
myMarker = new L.marker(e.latlng, {icon:icon, draggable:'true'});
myMarker.addTo(map);
newGetAddress(e.latlng, "ni");
};

map.on('click', onMapClick);
<?php
do_kml();
}

[mike]

var theLocale = <?php print get_variable('locale');?>;
var useOSMAP = <?php print get_variable('use_osmap');?>;
var initZoom = <?php print get_variable('def_zoom');?>;
init_map(2, <?php print get_variable('def_lat');?>, <?php print get_variable('def_lng');?>, "", parseInt(initZoom), theLocale, useOSMAP, "tr");
var bounds = map.getBounds();
var zoom = map.getZoom();
var got_points = false; // map is empty of points
var doReverse = <?php print intval(get_variable('reverse_geo'));?>;
function onMapClick(e) {

if(doReverse == 0) {return;}  this would be the line you're referring to. 

if(marker) {map.removeLayer(marker);}
if(myMarker) {map.removeLayer(myMarker);}
var iconurl = "./our_icons/yellow.png";
icon = new baseIcon({iconUrl: iconurl});
myMarker = new L.marker(e.latlng, {icon:icon, draggable:'true'});
myMarker.addTo(map);
newGetAddress(e.latlng, "ni");
};

map.on('click', onMapClick);
<?php
do_kml();
}

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/b0fc6a7e-eba7-43ff-891f-bd21dcf9206fn%40googlegroups.com.

[Eric Osterberg]

From the setting page:

To view this discussion on the web visit https://groups.google.com/d/msgid/open-source-cad/CADuRW1xyqDt6qJmVV63LiwUAX4vjqU0LxM2gRa_zsVFeUkp%3Dag%40mail.gmail.com.

[Eric Osterberg]

Looks like the API has changed again. The address attribute is not returned via this API method any longer.

https://nominatim.org/release-docs/develop/api/Reverse/ mentions this and requires people to use "address" lookup instead of "reverse". https://nominatim.org/release-docs/develop/api/Lookup/

I can see also when testing TicketCAD that the address attributes returned in this API query do not include the street address.  See this screenshot.

Unfortunately, JavaScript isn't really my area of expertise.

https://unpkg.com/leaflet-control-geocoder/dist/Control.Geocoder.js appears to be the latest version and it's far different from what's included in TicketsCAD.

Howto for using the GeoCoder at: https://github.com/perliedman/leaflet-control-geocoder/tree/master

TicketsCAD version at: https://github.com/openises/tickets/blob/main/js/Control.Geocoder.js