Make check fail

[Felix N]

Hello again,

Following the linux install tutorial I currently try to "make" the package.

During make check I encounter 2 of 96 fails.

The output is the following:

PASS: tools/rdm/ExpectedResultsTest.sh
mkdir -p ./python/ola/testing
touch ./python/ola/testing/__init__.py
ln -s -f ../../../tools/rdm ./python/ola/testing/rdm
echo "PYTHONPATH=./python /usr/bin/python3 ./tools/rdm/ResponderTestTest.py; exit \$?" > ./tools/rdm/ResponderTestTest.sh
chmod +x ./tools/rdm/ResponderTestTest.sh
FAIL: tools/rdm/ResponderTestTest.sh
mkdir -p ./python/ola
echo "PYTHONPATH=./python /usr/bin/python3 ./tools/rdm/TestHelpersTest.py; exit \$?" > ./tools/rdm/TestHelpersTest.sh
chmod +x ./tools/rdm/TestHelpersTest.sh
PASS: tools/rdm/TestHelpersTest.sh
mkdir -p ./python/ola/testing
touch ./python/ola/testing/__init__.py
ln -s -f ../../../tools/rdm ./python/ola/testing/rdm
echo "PYTHONPATH=./python /usr/bin/python3 ./tools/rdm/TestRunnerTest.py; exit \$?" > ./tools/rdm/TestRunnerTest.sh
chmod +x ./tools/rdm/TestRunnerTest.sh
FAIL: tools/rdm/TestRunnerTest.sh
mkdir -p ./python/ola
echo "PYTHONPATH=./python /usr/bin/python3 ./tools/rdm/TestStateTest.py; exit \$?" > ./tools/rdm/TestStateTest.sh
chmod +x ./tools/rdm/TestStateTest.sh
PASS: tools/rdm/TestStateTest.sh
============================================================================
Testsuite summary for OLA 0.10.9
============================================================================
# TOTAL: 96
# PASS:  94
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to open-l...@googlegroups.com
============================================================================
make[4]: *** [Makefile:16048: test-suite.log] Error 1
make[4]: Leaving directory '/home/felix/ola-0.10.9'
make[3]: *** [Makefile:16156: check-TESTS] Error 2
make[3]: Leaving directory '/home/felix/ola-0.10.9'
make[2]: *** [Makefile:17036: check-am] Error 2
make[2]: Leaving directory '/home/felix/ola-0.10.9'
make[1]: *** [Makefile:15933: check-recursive] Error 1
make[1]: Leaving directory '/home/felix/ola-0.10.9'
make: *** [Makefile:17039: check] Error 2

Should that worry me?
What can I do to fix this or can I just proceed with sudo make install?

Best, Felix

[Peter Newman]

Can you share your test-suite.log please, then we might be able to tell you?

I was going to suggest it might have been this, although that doesn't sound it from where you're getting the error:

https://github.com/OpenLightingProject/ola/pull/1835/files

[Felix N]

Hello Peter,

I later just continued with the installation and it completed without any further errors...

[Peter Newman]

That's good, but we'd still appreciate seeing the test-suite.log please, as it might indicate issues for you in future (depending on which bits of OLA you use) or others now.