changes to embed to show bill's explanation

Ayal Gelles

unread,

Jul 18, 2011, 8:29:14 AM7/18/11

to ofri raviv, bennydaon, Amit Zur, mush...@gmail.com, open-k...@googlegroups.com

this is my pull request - please review

https://github.com/hasadna/Open-Knesset/pull/17

Ayal Gelles

unread,

Jul 19, 2011, 5:58:05 AM7/19/11

to ofri raviv, bennydaon, Amit Zur, mush...@gmail.com, open-k...@googlegroups.com

היי

אני משפר כמה דברים בעמבעד שעופרי ציין אתמול:

- שהכותרת כבר תפנה לכנסת פתוחה

- שמתחת יהיה לינק ל"דברי הסבר" שיפתח את הפופאף

- שהטקסט יהיה קצת כהה יותר

- אנסה לתקן גם את הבאג בתצוגת hover של השלב הראשון

מישהו רוצה להוסיף משהו?

עופרי אם תוכל לדחוף את השינויים בAPI בלי תלות בזה, אני אשמח.

יומטוב.

Ayal Gelles

unread,

Jul 20, 2011, 9:24:02 AM7/20/11

to ofri raviv, bennydaon, Amit Zur, mush...@gmail.com, open-k...@googlegroups.com

heya

- I made changes that makes the explanation pop-up nicer now

- I did not make the title open the oknesset link to the bill since i re-thought about it and there might be a reason Mushon and Amit did not find it suitable - since it kind of defeats the pupose of the embed, no?

- I did not fix the unrelated "first-step-bug" as i think amit would have much less trouble dealing with it, Amit, are you still somehow working on the embed?

I pushed my recent changes to github, I think its pushable now - Ofri let me know what's what.

P.S - Please if any of you think i should not change the embed itself and try to do everything from "outside" let me know.

----

2011/7/19 Ayal Gelles <ay...@thewe.net>

Reply all

Reply to author

Forward