RFC: Making iSNS and SLP discovery code optional in open-iscsi?

[The Lee-Man]

Hi All:

I posted an issue on github about this, but I wanted to mention it here, as well.

As part of trying to make open-iscsi "container-ized", I have been looking at how to make the iscsi executable footprint smaller.

As part of that, I have been looking first at shared libraries being used by iscsid and iscsiadm. Of particular interest are libisns and libslp.

Open-iscsi uses both iSNS and SLP as optional discovery methods, instead of using "Send Targets". But neither of these are used much, and in particular the SLP code isn't even functional, as far as I know. (Yes, I need to test it.)

So I will soon submit a pull request to github making the meson build system have options to skip building iSNS and/or SLP discovery code.

I have a working prototype, but I need to clean it up before submitting it. For example, the man page will have to be updated to mention that these things are optional at build time. (It should do that now for systemd, but our man pages currently don't mention systemd at all.)

My belief is that making iSNS and SLP usage optional will benefit some of the users of open-iscsi, particularly when looking for a lightweight solution.

Anyone else think so?