Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

6 views
Skip to first unread message

John Garry

unread,
Feb 22, 2021, 3:32:50 AM2/22/21
to Yang Li, martin....@oracle.com, je...@linux.ibm.com, ldu...@suse.com, cle...@redhat.com, open-...@googlegroups.com, linux...@vger.kernel.org, linux-...@vger.kernel.org
On 22/02/2021 07:26, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for
> kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4312:61-62: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4456:61-62: WARNING opportunity
> for kobj_to_dev()

that API is not new, so please in future stop writing that. And 'new' is
a time-dependent term, and not appropriate to use anyway.

Thanks,
John

>
> Reported-by: Abaci Robot<ab...@linux.alibaba.com>
> Signed-off-by: Yang Li<yang...@linux.alibaba.com>

Reply all
Reply to author
Forward
0 new messages