[RFC-PATCH] dhcp provisioning support in cxgb3i

0 views
Skip to first unread message

Rakesh Ranjan

unread,
Oct 29, 2009, 9:16:52 AM10/29/09
to Mike Christie, da...@davemloft.net, James Bottomley, Karen Xie, Rakesh Ranjan, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org
Hi Mike,

Herein attached patches for having dhcp provisioning support in cxgb3i.
I have added one new iscsi netlink message ISCSI_UEVENT_REQ_IPCONF.
Please have a look and share suggestions.

Regards
Rakesh Ranjan

0001-added-one-new-netlink-message-ISCSI_UEVENT_REQ_IPCON.patch
0002-Implemented-dhcp-client-support-in-cxgb3i.patch

Ben Hutchings

unread,
Oct 29, 2009, 10:06:54 AM10/29/09
to Rakesh Ranjan, Mike Christie, da...@davemloft.net, James Bottomley, Karen Xie, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org
On Thu, 2009-10-29 at 18:46 +0530, Rakesh Ranjan wrote:
> Hi Mike,
>
> Herein attached patches for having dhcp provisioning support in
> cxgb3i.
> I have added one new iscsi netlink message ISCSI_UEVENT_REQ_IPCONF.
> Please have a look and share suggestions.
[...]

Why does cxgb3i need its very own DHCP client? This seems like
something that's generically useful to firmware-based iSCSI adapters.

(It would be better still if this could be left to user-space, but
although a user-space program could send out requests on the net device
using the iSCSI device's MAC address, I don't see how it would get
replies.)

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Mike Christie

unread,
Oct 29, 2009, 5:09:56 PM10/29/09
to Rakesh Ranjan, da...@davemloft.net, James Bottomley, Karen Xie, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org
Rakesh Ranjan wrote:
> Hi Mike,
>
> Herein attached patches for having dhcp provisioning support in cxgb3i.
> I have added one new iscsi netlink message ISCSI_UEVENT_REQ_IPCONF.

Is the idea to have iscsid/uip send down this msg?

Was it not possible to hook in more like how bnx2i does dhcp?

Rakesh Ranjan

unread,
Oct 30, 2009, 1:24:00 AM10/30/09
to Mike Christie, da...@davemloft.net, James Bottomley, Karen Xie, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org

yep, idea is to have iscsid send down ISCSI_UEVENT_REQ_IPCONF msg. bnx2i
approach in our case for at least T3 is not feasible.

Regards
Rakesh Ranjan

Mike Christie

unread,
Nov 2, 2009, 6:48:20 PM11/2/09
to Rakesh Ranjan, da...@davemloft.net, James Bottomley, Karen Xie, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org

I think adding DHCP in the kernel is getting a little crazy :) If we go
down this path, I agree with the other person that stated it should at
least be generic.

Rakesh Ranjan

unread,
Nov 4, 2009, 1:24:07 PM11/4/09
to Mike Christie, da...@davemloft.net, James Bottomley, Karen Xie, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org, Rakesh Ranjan

Hi Mike,

What do you mean be generic ? Do you want to have a generic interface
for DHCP handler that could be part of libiscsi and could be used by
other LLD's.

Regards
Rakesh Ranjan

Stephen Hemminger

unread,
Nov 4, 2009, 2:09:04 PM11/4/09
to Rakesh Ranjan, Mike Christie, da...@davemloft.net, James Bottomley, Karen Xie, open-...@googlegroups.com, LKML, linux...@vger.kernel.org, net...@vger.kernel.org, Rakesh Ranjan

Is there anyway to make existing code (in net/ipv4/ipconfig.c) more generic
and useful for both?

Reply all
Reply to author
Forward
0 new messages