Re: [PATCH] open-iscsi: Fix memory leak in sysfs_get_str

[Lee Duncan]

On 11/4/20 6:59 PM, Wenchao Hao wrote:
> strlen(sysfs_value) return 0 do not mean sysfs_value
> is NULL and this memory should be freed
>
> Signed-off-by: Wenchao Hao <haowe...@huawei.com>
> ---
> usr/sysfs.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/usr/sysfs.c b/usr/sysfs.c
> index 2488160..8d37c69 100644
> --- a/usr/sysfs.c
> +++ b/usr/sysfs.c
> @@ -574,8 +574,12 @@ int sysfs_get_str(char *id, char *subsys, char *param, char *value,
>
> value[0] = '\0';
> sysfs_value = sysfs_get_value(id, subsys, param);
> - if (!sysfs_value || !strlen(sysfs_value))
> + if (!sysfs_value)
> + return EIO;
> + if (!strlen(sysfs_value)) {
> + free(sysfs_value);
> return EIO;
> + }
>
> len = strlen(sysfs_value);
> if (len && (sysfs_value[len - 1] == '\n'))
>

Reviewed-by: Lee Duncan <ldu...@suse.com>

[Wenchao Hao]

--
2.27.0