[PATCH] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
11 views
Skip to first unread message
Jing Xiangfeng
Jun 20, 2020, 1:10:40 PM6/20/20
to ldu...@suse.com, cle...@redhat.com, je...@linux.ibm.com, martin....@oracle.com, open-...@googlegroups.com, linux...@vger.kernel.org, linux-...@vger.kernel.org, linu...@kvack.org, jingxi...@huawei.com
If scsi_host_lookup() failes we will jump to put_host, which may
cause panic. Jump to exit_set_fnode to fix it.
Signed-off-by: Jing Xiangfeng <jingxi...@huawei.com>
---
drivers/scsi/scsi_transport_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index f4cc08e..c5e99f9 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
pr_err("%s could not find host no %u\n",
__func__, ev->u.set_flashnode.host_no);
err = -ENODEV;
- goto put_host;
+ goto exit_set_fnode;
}
idx = ev->u.set_flashnode.flashnode_idx;
--
1.8.3.1
cause panic. Jump to exit_set_fnode to fix it.
Signed-off-by: Jing Xiangfeng <jingxi...@huawei.com>
---
drivers/scsi/scsi_transport_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index f4cc08e..c5e99f9 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
pr_err("%s could not find host no %u\n",
__func__, ev->u.set_flashnode.host_no);
err = -ENODEV;
- goto put_host;
+ goto exit_set_fnode;
}
idx = ev->u.set_flashnode.flashnode_idx;
--
1.8.3.1
Mike Christie
Jul 26, 2020, 1:31:55 AM7/26/20
to Jing Xiangfeng, ldu...@suse.com, cle...@redhat.com, je...@linux.ibm.com, martin....@oracle.com, open-...@googlegroups.com, linux...@vger.kernel.org, linux-...@vger.kernel.org, linu...@kvack.org
Martin K. Petersen
Jul 29, 2020, 12:12:53 AM7/29/20
to Jing Xiangfeng, je...@linux.ibm.com, cle...@redhat.com, ldu...@suse.com, Martin K . Petersen, open-...@googlegroups.com, linux-...@vger.kernel.org, linux...@vger.kernel.org, linu...@kvack.org
On Mon, 15 Jun 2020 16:12:26 +0800, Jing Xiangfeng wrote:
> If scsi_host_lookup() failes we will jump to put_host, which may
> cause panic. Jump to exit_set_fnode to fix it.
Applied to 5.9/scsi-queue, thanks!
> If scsi_host_lookup() failes we will jump to put_host, which may
> cause panic. Jump to exit_set_fnode to fix it.
[1/1] scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
https://git.kernel.org/mkp/scsi/c/68e12e5f6135
--
Martin K. Petersen Oracle Linux Engineering
Reply all
Reply to author
Forward
0 new messages