Getting comment XMPP packet seems wrong on Web client

Skip to first unread message

Mickaël Rémond

Feb 5, 2011, 12:54:17 PM2/5/11
to onesocialweb

I think that the packet to get the comments on a node is wrong.
The web client sends somthing like:

<iq type="get" to="mremond@localhost" id="osw_6"
from="mremond@localhost/1296928155094"><pubsub xmlns="http://"><items xmlns="
pubsub" node="urn:xmpp:microblog:0:replies:item=urn:uuid:76668daa-
cfbf-44df-ad35-c5d7e6bbb23c"><item xmlns="
pubsub" id="urn:uuid:76668daa-cfbf-44df-ad35-c5d7e6bbb23c" /></items></

The node is the item you are replying to:

It cannot be the same as the id you are looking (on the item tag):

Currently, in ejabberd implementation we make an ugly case to ignore
the id on the item tag especially for queries on reply node, but I
think it need to be change.

Am I missing something ?

Mickaël Rémond

Diana Cheng

Feb 6, 2011, 12:39:15 PM2/6/11
to onesocialweb
Hi Mickael,

You are right, sorry for this actually, I hadn't realize an item was
being sent in the stanza. The correct packet should be just:

<iq id="G3u2A-7" to="joh...@onesocialweb.local" type="get">
<pubsub xmlns=''>
<items node='urn:xmpp:microblog:0:replies:item=urn:uuid:
16212643-30d5-40fb-85ce-2f983063f6db' />

I have pushed the changes to git and I will deploy this fix on our
servers ( and tomorrow (when the network
is up again :-/ ) and you can test getting the comments with your
implementation again. Could everyone else update their web client and
plugin too, please? (there are changes in the plugin, lib-java and lib-
gwt) Sorry about that!

Many thanks,

Mickaël Rémond

Feb 6, 2011, 12:44:54 PM2/6/11
to onesocialweb
Hello Diana,

No problem.
Many thanks for the fast fix !

I need to finish my laptop setup to be able to rebuild all directly
and thus test on latest changes.

Thank you!

Diana Cheng

Feb 8, 2011, 8:20:14 AM2/8/11
to onesocialweb
There is also a change in the osw-model which needs to be pulled. For
all those people that have had trouble getting this last fix to work.
Sorry for not mentioning this. Hope it works without problems now.

Diana Cheng

Feb 8, 2011, 8:22:39 AM2/8/11
to onesocialweb

There is also an update in the Android market (new build with the osw-
lib-java which includes this last change). Feel free to upgrade.

Reply all
Reply to author
0 new messages