Disk drive icon customization

[OneCommander Support]

I am considering making it possible to customize drive icons. 

It should be something similar to customizing folder icons

https://gist.github.com/m1l/84d32f013ed7431405eeab0c32fac96e

but there are a few things to consider"

- We can't have them customized by drive letter (like DriveD.png) as your external disk might be drive D: today and E: the next time you plug in, or USB stick might get that drive letter 

- We can't have them customized by drive name as most people have blank drive names

- By serial number maybe, but how will user know what is serial number of disk

- Just by type? The problem is that Windows defines just a few types like "Fixed","Removable","Network","CDRom". But most external disks are also reported "Fixed" and I have not found a way to detect interface like USB to figure out that it is external disk. Also there is no elegant way if it is HDD or SSD (there may be a way by to checking how fast it spins, as if Windows is still stuck in 1990)

- What happens if USB stick comes with an icon - It would look bad with both custom icons and random icons that comes with s drive

- Would it be with \FolderIcons as a part of a pack or a new folder/pack like DriveIcons?

[Neko San]

Hello, as you can guess I like very much the idea :-)

If I can: 

1. I think the "by type" thing should be OK/enough. 

2. Perhaps with an option to also recognize (or not, and stay generic) custom drive icons in the old way relying on the "autoexec.inf" if it exists on the drive root to display an *.ico file placed on that drive?

3. I think a \DriveIcons\PackName in the Resources directory is OK, as it should be easier to implement if you can keep the same kind of structure as today ? (despite the fact that installing a complete pack can be view as "complexe" since you must put the "PackName" files in each respective folder)
Or you could adopt a different way : Icons\%PackName%\DriveIcons,  Icons\%PackName%\FolderIcons" and so on, to make a pack installation easier (we would just have to drop the Pack on this "Icons" folder) ?
Just my two cents ;-)
Best regards,