Fwd: omaha-discuss - Google Groups: Message Pending [{IImWvvuq7ZfiECoCaWcwAA8FKDOSDg2s0}]

[Sorin Jianu]

Somehow the message below got lost. 

It does look like a code bug at the first glance.

---------- Forwarded message ----------
From: nir.ma...@gmail.com
To: omaha-...@googlegroups.com
Cc: 
Date: Tue, 23 Jun 2015 22:41:17 -0700 (PDT)
Subject: base/logging.cc: "ERROR - Cannot create ETW log writer"

Hi All,

I'm not part of Google Omaha, but while using DebugView, I noticed this message come up a lot:

"ERROR - Cannot create ETW log writer"

I looked up the code in Google Code, in logging.cc line 362:

if (etw_log_writer_ == NULL) {

etw_log_writer_ = EtwLogWriter::Create();

if (debug_out_writer_ == NULL) { // <--- line 362

OutputDebugString(SPRINTF(L"LOG_SYSTEM: [%s]: ERROR - "

L"Cannot create ETW log writer",

proc_name_));

}

}

Shouldn't debug_out_writer_ in line 362 actually be etw_log_writer_ ?

Thanks,

Nir