Issue 37 in omaha: Log message in installer_wrapper.cc dereferences hresult as string

[om...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 37 by ben.chal...@red-gate.com: Log message in
installer_wrapper.cc dereferences hresult as string
http://code.google.com/p/omaha/issues/detail?id=37

This one is quite simple so I won't fill in a full report. Patch below.

goopdate/installer_wrapper.cc at SVN rev 109.

@@ -420,7 +420,7 @@
Process p(executable_path, NULL);
HRESULT hr = p.Start(command_line, user_token);
if (FAILED(hr)) {
- OPT_LOG(LE, (_T("[p.Start fail][hr][%s][%s]"),
+ OPT_LOG(LE, (_T("[p.Start fail][0x%x][%s][%s]"),
hr, executable_path, command_line));
set_error_extra_code1(static_cast<int>(hr));
return GOOPDATEINSTALL_E_INSTALLER_FAILED_START;

[om...@googlecode.com]

Updates:
Status: Fixed

Comment #1 on issue 37 by ryan...@google.com: Log message in

installer_wrapper.cc dereferences hresult as string
http://code.google.com/p/omaha/issues/detail?id=37

Thanks Ben :)